Closed
Bug 812280
Opened 13 years ago
Closed 13 years ago
IonMonkey: rm move32/movePtr overloads that take an Address
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
15.20 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
On IRC somebody asked whether move32/movePtr dereference the source operand. In most cases they don't, but there are overloads that take an Address. For consistency this patch removes these and changes the callers to use load32/loadPtr instead.
Attachment #682104 -
Flags: review?(dvander)
Comment on attachment 682104 [details] [diff] [review]
Patch
Review of attachment 682104 [details] [diff] [review]:
-----------------------------------------------------------------
oh wow, I never noticed this. r=me with prejudice
Attachment #682104 -
Flags: review?(dvander) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•