Closed Bug 812280 Opened 9 years ago Closed 9 years ago

IonMonkey: rm move32/movePtr overloads that take an Address

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
On IRC somebody asked whether move32/movePtr dereference the source operand. In most cases they don't, but there are overloads that take an Address. For consistency this patch removes these and changes the callers to use load32/loadPtr instead.
Attachment #682104 - Flags: review?(dvander)
Comment on attachment 682104 [details] [diff] [review]
Patch

Review of attachment 682104 [details] [diff] [review]:
-----------------------------------------------------------------

oh wow, I never noticed this. r=me with prejudice
Attachment #682104 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/4d3a1e4228ac
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.