812286 - BaseException.message deprecated as of Python 2.6

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andrew Halberstadt [:ahal]]

In errors.py we inherit from BaseException instead of Exception. This causes Python to spit out a deprecation warning which aki theorizes is causing mozharness to read the exception messages wrongly.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Fix deprecation warning

I was wrong, it wasn't that we were subclassing BaseException, it's that we were setting the self.message attribute which is apparently already defined and also deprecated. To work around, I changed the name of the variable to avoid collision.

I wasn't able to reproduce the deprecation warning locally for some reason, but this should fix it. I at least tested to make sure it won't cause any harm.

I also switched str() to repr() as that will give us better string representations if we happen to pass in arbitrary objects as the message.

Comment 2

[Andrew Halberstadt [:ahal]]

Actually on second thought, I'll just leave it as str().. won't bother uploading a new patch though.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 682149 [details] [diff] [review]
Patch 1.0 - Fix deprecation warning

Cool, thanks.

Comment 4

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0dc317eeeec4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0dc317eeeec4

Comment 6

[Andrew Halberstadt [:ahal]]

This didn't end up being the reason for mozharness reading the error messages wrong so I'm not going to bother porting it to aurora.

Comment 7

[Jonathan Griffin (:jgriffin)]

Uplifted to mozilla-b2g18 for bug 842626:  https://hg.mozilla.org/releases/mozilla-b2g18/rev/41a1f715c87a

Comment 8

[Jonathan Griffin (:jgriffin)]

This needs to be uplifted to mozilla-b2g18/v1_0_1 to resolve the perma-orange Mn tests.  It's test-only.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4d8c2edf7c09