Closed Bug 812328 Opened 12 years ago Closed 5 years ago

Pull STL container headers out of GLContext.h

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jgilbert, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: webgl-internal) 

Where we currently have
#include <set>
...
std::set<GLuint> GLContext::mFoo;

We should switch to:
template<typename T>
class std::set<T>;
...
nsAutoPtr< std::set<GLuint> > GLContext::mFoo;

My syntax might be a little off, but that's the idea. This way we don't need to include <set> in GLContext.h, which we include all over.

FWIW, this should make bug 811958 unnecessary, but that bug should happen anyways. (Disentangling headers, moving TextureImage classes out of GLContext land)
Depends on: 811181
Severity: normal → trivial
Whiteboard: webgl-internal

Incurring an extra memory indirection is worse.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.