812372 - Refactoring: Rename DocumentViewerImpl to be nsDocumentViewer

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Scott Johnson (:jwir3)]

I get caught up with tools that search for classes (e.g. Eclipse) because I expect this class to be prefixed with 'ns', as many of our other classes are. We should change this... probably pretty low-risk, but it will break blame in some cases.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If you're going to do this, use nsDocumentViewer (lose the "Impl" as well).

Comment 2

[Scott Johnson (:jwir3)]

Attachment: b812372

Created using the following automated command (on linux):

find . -name "*.js" -o -name "*.cpp-o -name "*.c" -o -name "*.h" -o -name "*.html" -exec sed -i "s/DocumentViewerImpl/nsDocumentViewer/g" '{}' \;

Comment 3

[Scott Johnson (:jwir3)]

Comment on attachment 683399 [details] [diff] [review]
b812372

Re-requesting review from ehsan, since dbaron's review queue is super high. :)

Comment 4

[(no longer active)]

Comment on attachment 683399 [details] [diff] [review]
b812372

Review of attachment 683399 [details] [diff] [review]:
-----------------------------------------------------------------

r=sucker!

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/91dfecde7a96