812387 - When enabling wifi from quick settings, we request all settings 6 times

Status: RESOLVED DUPLICATE of bug 840322

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Gregor Wagner [:gwagner]]

When I enable wifi from the quick-settings menue, we open the settings app.
I enabled logging for the settings API and I see that we request all settings 6 times.

I/Gecko   (  109): -*- SettingsManager: observe callback called! wifi.enabled 5
I/Gecko   (  109): -*- SettingsManager: Settings::receiveMessage: Settings:Change:Return:OK
I/Gecko   (  109): -*- SettingsManager: Settings:Change:Return:OK
I/Gecko   (  109): -*- SettingsManager: data:wifi.enabled:true
I/Gecko   (  109): 
I/Gecko   (  757): -*- SettingsManager: get lock!
I/Gecko   (  757): -*- SettingsManager: get: *
I/Gecko   (  757): -*- SettingsManager: info: get
I/Gecko   (  757): -*- SettingsManager: get lock!
I/Gecko   (  757): -*- SettingsManager: get: *
I/Gecko   (  757): -*- SettingsManager: info: get
I/Gecko   (  757): -*- SettingsManager: get lock!
I/Gecko   (  757): -*- SettingsManager: get: *
I/Gecko   (  757): -*- SettingsManager: info: get
I/Gecko   (  757): -*- SettingsManager: get lock!
I/Gecko   (  757): -*- SettingsManager: get: *
I/Gecko   (  757): -*- SettingsManager: info: get
I/Gecko   (  757): -*- SettingsManager: get lock!
I/Gecko   (  757): -*- SettingsManager: get: *
I/Gecko   (  757): -*- SettingsManager: info: get
I/Gecko   (  757): -*- SettingsManager: get lock!
I/Gecko   (  757): -*- SettingsManager: get: *
I/Gecko   (  757): -*- SettingsManager: info: get
I/Gecko   (  757): -*- SettingsManager: Request for '*' successful. Record count: 103....


When I just open the settings app, we request all settings one time.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

These queries are generated by lazy loading of settings app. There are 6 sections related to wifi.

E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:61 in settings_init: ****init****
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel**** 
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:78 in settings_loadPanel: ****loadPanel**** wifi-status
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel**** 
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:78 in settings_loadPanel: ****loadPanel**** wifi-auth
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel**** 
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:78 in settings_loadPanel: ****loadPanel**** wifi-joinHidden
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel**** 
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:78 in settings_loadPanel: ****loadPanel**** wifi-wps
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel**** 
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:78 in settings_loadPanel: ****loadPanel**** wifi-manageNetworks
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel**** 
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:78 in settings_loadPanel: ****loadPanel**** wifi
E/GeckoConsole(11646): Content JS LOG at app://settings.gaiamobile.org/js/settings.js:130 in settings_presetPanel: ****presetPanel****

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The UX for the wifi quick-setting has changed so this bug as originally filed is now invalid, but the problem of requesting the entire DB on each panel change is fixed by bug 840322.