812404 - [b2g-bluetooth] Crash when connect with a bluetooth headset right after pairing completed

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

Repro:
- Enable bluetooth
- Pair with a bluetooth headset
- Connect with it immediately

Expected:
- Connect success

Actual:
- Crashed




In the implementation of settings app, after pairing with a bluetooth headset, we'll automatically connect with it after 5 seconds. However, user might try to connect with the headset at this time, resulting in b2g crashed, so we need to handle this situation.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Return when connection status is connecting

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 682305 [details] [diff] [review]
Patch 1(v1): Return when connection status is connecting

Review of attachment 682305 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits addressed.

::: dom/bluetooth/ipc/BluetoothServiceChildProcess.cpp
@@ +301,2 @@
>    SendRequest(aRunnable,
>                ConnectRequest(nsString(aDeviceAddress), 

nit: an additional blank

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +2314,1 @@
>    NS_WARNING("Unknow Profile");

nit: a typo here, please help to fix. :)

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Return when connection status is connecting, r=echou

try:
https://tbpl.mozilla.org/?tree=Try&rev=c3d3ff55d5f7
https://tbpl.mozilla.org/?tree=Try&rev=0dd3d03c302d

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Return when connection status is connecting, r=echou

https://tbpl.mozilla.org/?tree=Try&rev=4edca193359f
https://tbpl.mozilla.org/?tree=Try&rev=4410e7a3b87b

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92d67fe470b4

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/92d67fe470b4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/806ce0cf38e2