Closed Bug 812423 Opened 8 years ago Closed 7 years ago

Valgrind on tbpl detects leak - 136 bytes are definitely lost (direct) with js::ArgumentsObject* js::ArgumentsObject::create on the stack

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
major

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: gkw, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak, regression, valgrind)

Attachments

(2 files)

Valgrind detects a leak of 136 bytes (direct) with js::ArgumentsObject* js::ArgumentsObject::create on the stack, see attached snippet which comes from:

https://tbpl.mozilla.org/php/getParsedLog.php?id=17064538&tree=Firefox&full=1

m-c changeset rev is a761bfc192b5.

It didn't happen in the previous Valgrind run here: https://tbpl.mozilla.org/?noignore=1&jobname=valgrind&rev=dd68409d7810

So I'm guessing the regression range is:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dd68409d7810&tochange=a761bfc192b5
Bug 809021 maybe? I can't tell if the arguments it talking about are the same as the arguments object...
gkw: Might this be related to Bug 829421 ?

Apparently they had the same error reported on the gnome-shell.  Strangely, this might be a valgrind error, because this would only happen in case of OOM.
Flags: needinfo?(gary)
Thanks, Nicolas! I've removed the suppression for this in https://hg.mozilla.org/mozilla-central/rev/425835f6a9e2

Assuming fixed by bug 829421.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(gary)
Resolution: --- → FIXED
Reopening. I still see this on 64-bit builds after removing the suppression, see bug 829421 comment 15 and 16.

Suppression re-added by backing out suppression removal changeset: https://hg.mozilla.org/mozilla-central/rev/19f630648c80
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is no longer occurring in Valgrind-on-TBPL runs.
Status: REOPENED → RESOLVED
Closed: 8 years ago7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.