812430 - [SETTINGS][BLUETOOTH] First time connected by laptop would crash the phone

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Walter Chen[:ypwalter][:wachen]]

*Environment:
Phone - Unagi
gaia master(git): 487a7c18c8ff08db7d2e76239e85e3e5eefcc8b7
gecko aurora(hg): 0d76df6f808d

Please note that this bug is not reproducible in Otoro phone

*How to reproduce:
  0. Make sure "Settings" app got killed
  1. Go to "Settings" > "Bluetooth"
  2. Enable Bluetooth, and set "Visible to all"
  3. Pair it from laptop

*Expected Result:
  showing message of pin and laptop name

*Actual Result:
  shows empty screen with 2 lines

*sidenote:
  only valid when settings first run. (otherwise, you need to kill settings to redo it)

Comment 1

[Walter Chen[:ypwalter][:wachen]]

Attachment: pic

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Clear bluetooth signal table while process is killed

I followed the reproduce steps, but the result is different:
B2G phone crashed after receiving pairing message

This issue is resolved in the patch. Please help to verify. Thanks.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 683053 [details] [diff] [review]
Patch 1(v1): Clear bluetooth signal table while process is killed

Review of attachment 683053 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit addressed.

::: dom/bluetooth/BluetoothManager.cpp
@@ +62,5 @@
> +    if (v.type() != BluetoothValue::TArrayOfBluetoothNamedValue) {
> +      NS_WARNING("Not a BluetoothNamedValue array!");
> +      SetError(NS_LITERAL_STRING("BluetoothReplyTypeError"));
> +      return false;
> +    }

v.type() has to be BluetoothValue::TArrayOfBluetoothNamedValue, otherwise it would be a serious error. How about using MOZ_ASSERT() here?

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Clear bluetooth signal table while process is killed, r=echou

try server:
https://tbpl.mozilla.org/?tree=Try&rev=9e1ed4e5335f
https://tbpl.mozilla.org/?tree=Try&rev=af31dc88d99e

Comment 6

[Walter Chen[:ypwalter][:wachen]]

During the process, Gina figured out stuffs related with crashing system when pairing. The empty system message was found in bug 813440. After bug 813440 solved, I will be verifying both fix simultaneously. (mark as depends on 813440 since there were 2 issues in this bug)

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d03453c186e9

Comment 8

[Josh Carpenter [:jcarpenter]]

Casey, can you provide the expected result specs here?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d03453c186e9

Comment 10

[Walter Chen[:ypwalter][:wachen]]

Hi,

Please refer to my comment 6.
I think my English is too bad for people to understand after several bugzilla misunderstood.
Let me list it here:
1. That fix was to fix the crashing of system found during the reproduction of this bug.
2. The empty message issue still occurred
3. I will be verifying both of them simultaneously after Gina finished it.

Comment 11

[Walter Chen[:ypwalter][:wachen]]

Since we got another bug tracking on empty system message, this one can closed for fixing the crashing issue.

Thanks

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c2ca6b7c432
https://hg.mozilla.org/releases/mozilla-beta/rev/6c1632c71b81

(BTW, my bb+ uplift bug queries don't look at bugs filed under the Gaia component, FWIW)

Comment 13

[Walter Chen[:ypwalter][:wachen]]

https://releases.mozilla.com/b2g/ verified in 20121212 build