812443 - [Window manager] Home screen is always set to visible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Looks like we got a typo in Bug #806425!

I have spotted the typo at |toggleHomescreen|, but I would like to test trusted UI before submit it.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/6452

I am carrying over the blocking+ from the cloned bug; I don't think this should be a non-blocking bug anyway :-/

Let's get this quickly through review. ferjmoreno can you confirm the change? I have tested the payment UI through UI tests and verify the visibility change in home screen with console.log() in landing.js

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 682373 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/6452

vingtetun, if you are awake...

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 682373 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/6452

We've talked over IRC and we figured that an additional fix is required to avoid hiding the homescreen after reopening an app hosting a trusted UI. I'll be sending a PR with this fix right away.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6459

Pointer to Github pull-request

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 682413 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6459

r=me. I don't like the fact that this fix brings dependency of window manager to trusted UI, but this seems to be the minimal fix.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/6459

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #2)
> Comment on attachment 682373 [details]
> Github: https://github.com/mozilla-b2g/gaia/pull/6452
> 
> vingtetun, if you are awake...

No way. My sleep schedule is completely f*** up :(