Closed Bug 812466 Opened 11 years ago Closed 11 years ago

namespacify Accessible classes

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

patch
90.40 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
      No description provided.
Attachment #682401 - Flags: review?(trev.saunders)
Comment on attachment 682401 [details] [diff] [review]
patch

it would be nice if the typedefs where protected / private when possible.

rs=me
Attachment #682401 - Flags: review?(trev.saunders) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> Comment on attachment 682401 [details] [diff] [review]
> patch
> 
> it would be nice if the typedefs where protected / private when possible.
> 
> rs=me

they are really temporary, why would we care?
(In reply to alexander :surkov from comment #2)
> (In reply to Trevor Saunders (:tbsaunde) from comment #1)
> > Comment on attachment 682401 [details] [diff] [review]
> > patch
> > 
> > it would be nice if the typedefs where protected / private when possible.
> > 
> > rs=me
> 
> they are really temporary, why would we care?

I don't alot but basically because why shouldn't they be?
(In reply to Trevor Saunders (:tbsaunde) from comment #3)

> > they are really temporary, why would we care?
> 
> I don't alot but basically because why shouldn't they be?

they shouldn't be, just I would like to avoid one more iteration in this
(In reply to alexander :surkov from comment #4)
> (In reply to Trevor Saunders (:tbsaunde) from comment #3)
> 
> > > they are really temporary, why would we care?
> > 
> > I don't alot but basically because why shouldn't they be?
> 
> they shouldn't be, just I would like to avoid one more iteration in this

ok, I don't see why it would be, but if its going to cause trouble merging stuff in your queue don't worry about it or land it as a follow up when convienent?
ok, good
https://hg.mozilla.org/mozilla-central/rev/5cb2cc9be615
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.