8125 - nsString2::ToInteger fails to set error code

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Simon Fraser [no longer active]]

On investigating the window sizing problem in apprunning, I notice that
PRInt32 nsString2::ToInteger(PRInt32* anErrorCode) fails to set the error
code in some cases.

The implemenation looks like:
{
  nsAutoString2 theString(*this,eOneByte);
  PRUint32  theRadix=10;
  PRInt32   result=GetNumericSubstring(theString,theRadix);

  if(NS_OK==result){
    result=_ToInteger(theString,anErrorCode,theRadix);
  }
  return result;
}

If called on an empty string, GetNumericSubstring() returns an error
code, but this is never set in *anErrorCode before return. So in this
situation, *anErrorCode is left unset, and the function returns a large
negative value.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Proposed fix

Comment 2

[rickg]

Added more error reporting to this method. In particular, if you hand in a plain
text string, or an empty string you'll get an error code.

Comment 3

[Chris Petersen]

Rick-  I would verify this fix in the latest build. Can I verify this with a test
case ?

Comment 4

[Chris Petersen]

Marking verified fixed.