812528 - Port speculativeConnect changes to search.xml from bug 804655 and bug 722979

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: Comment 1]

Bug 804655 removed the third parameter from nsISpeculativeConnect's speculativeConnect method, which is only called in search.xml as far as suite code is concerned.

Original changeset: http://hg.mozilla.org/mozilla-central/rev/0d391f23c422

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 682484 [details] [diff] [review]
patch [Checkin: Comment 1]

http://hg.mozilla.org/comm-central/rev/fabc7ce77ee2

Comment 2

[Philip Chee]

speculativeConnect changed again in Bug 722979 - Add privacy status argument to relevant nsIStrictTransportSecurityService methods

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: port bug 722979 [Checkin: Comment 7]

Not sure whether we need this, seems to work with/without the patch.

Comment 4

[[e-mail]]

Comment on attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

This is for support for private browsing windows. I can't remember what we did in other cases when private browsing support was added to shared APIs.

Comment 5

[Philip Chee]

We either passed null or a chrome window depending.

Comment 6

[[e-mail]]

Comment on attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

Can't hurt, I guess. Just on a style nit though, I'd prefer to have callbacks declared before searchURI.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

http://hg.mozilla.org/comm-central/rev/ceaec9a12250

Hmm, personally I prefer declaring in order of use, but here you are.