Port speculativeConnect changes to search.xml from bug 804655 and bug 722979

RESOLVED FIXED in seamonkey2.16

Status

SeaMonkey
Search
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.16

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 682484 [details] [diff] [review]
patch [Checkin: Comment 1]

Bug 804655 removed the third parameter from nsISpeculativeConnect's speculativeConnect method, which is only called in search.xml as far as suite code is concerned.

Original changeset: http://hg.mozilla.org/mozilla-central/rev/0d391f23c422
Attachment #682484 - Flags: review?(neil)

Updated

5 years ago
Attachment #682484 - Flags: review?(neil) → review+
(Assignee)

Comment 1

5 years ago
Comment on attachment 682484 [details] [diff] [review]
patch [Checkin: Comment 1]

http://hg.mozilla.org/comm-central/rev/fabc7ce77ee2
Attachment #682484 - Attachment description: patch → patch [Checkin: Comment 1]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.16

Comment 2

5 years ago
speculativeConnect changed again in Bug 722979 - Add privacy status argument to relevant nsIStrictTransportSecurityService methods
(Assignee)

Comment 3

5 years ago
Created attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

Not sure whether we need this, seems to work with/without the patch.
Attachment #682737 - Flags: review?(neil)

Comment 4

5 years ago
Comment on attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

This is for support for private browsing windows. I can't remember what we did in other cases when private browsing support was added to shared APIs.

Comment 5

5 years ago
We either passed null or a chrome window depending.

Comment 6

5 years ago
Comment on attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

Can't hurt, I guess. Just on a style nit though, I'd prefer to have callbacks declared before searchURI.
Attachment #682737 - Flags: review?(neil) → review+
(Assignee)

Comment 7

5 years ago
Comment on attachment 682737 [details] [diff] [review]
port bug 722979 [Checkin: Comment 7]

http://hg.mozilla.org/comm-central/rev/ceaec9a12250

Hmm, personally I prefer declaring in order of use, but here you are.
Attachment #682737 - Attachment description: port bug 722979 → port bug 722979 [Checkin: Comment 7]
(Assignee)

Updated

5 years ago
Summary: Port speculativeConnect changes to search.xml from bug 804655 → Port speculativeConnect changes to search.xml from bug 804655 and bug 722979
You need to log in before you can comment on or make changes to this bug.