812618 - Autocomplete at cursor location

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Mihai Sucan [:msucan]]

STR:

1. Open the Web Console.
2. Type "inspect()" without quotes.
3. Press Left once and type "document.". Try Tab.

By now I would expect I get completion suggestions for document. If I press Delete once, I do.

Proposed fix: simply take into consideration for completion what is up to the cursor location. That way we can get more helpful completion when we write more complicated code.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: wip

The point of this work is to allow non-linear writing of code. Most often I do not write code linearly. Sometimes I jump a line back (during multiline input editing), or I jump at the start of the line to add a call, a variable, etc.

I am also of the habit of typing opening and closing parenthesis then move back one char to type the arguments: eg. I write linearly document.body.appendChild(), then move in (), then type foobarVar, then press enter.

Showing completion suggestions would ease typing in most cases. I also believe that non-linear writing of code is quite often among developers.

Please play with the patch. I would really like this kind of autocomplete. Also compare with chrome.

If you are undecided, maybe we can ask others from the team to also play with the patch.

Suggestions for improvements are welcome. Thanks!

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 765991 [details] [diff] [review]
wip

Review of attachment 765991 [details] [diff] [review]:
-----------------------------------------------------------------

yeah, this looks reasonable, I think.

Comment 3

[Mihai Sucan [:msucan]]

Attachment: proposed patch

Thanks for testing and for the f+!

This is the same as the wip, but with added toolkit and browser tests. Offsets were incorrect in the toolkit tests for autocomplete, otherwise these changes do not cause any existing tests to break.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=e487625f28d0

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 769048 [details] [diff] [review]
proposed patch

Review of attachment 769048 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. :)

::: browser/devtools/webconsole/webconsole.js
@@ +4261,5 @@
>        let suffix = currentItem.label.substring(this.lastCompletion.
>                                                 matchProp.length);
> +      let cursor = this.inputNode.selectionStart;
> +      let value = this.inputNode.value;
> +      this.setInputValue(value.substr(0, cursor) + suffix + value.substr(cursor));

kind of amazing we didn't do this before.

Comment 5

[Mihai Sucan [:msucan]]

Thanks for the review!

Landed:
https://hg.mozilla.org/integration/fx-team/rev/a33d8389d454

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a33d8389d454