812622 - Reply-to-all with no text selected leads to assertion in debug builds

Status: RESOLVED DUPLICATE of bug 827061

(MailNews Core :: Composition, defect)

Description

[:Irving Reid (No longer working on Firefox)]

###!!! ASSERTION: Bad position passed to nsJISx4051LineBreaker::Next: 'aLen > aPos', file /Users/ireid/tbird/comm-central/mozilla/intl/lwbrk/src/nsJISx4501LineBreaker.cpp, line 785


The top of the call stack is:

#0	0x000000010176c651 in nsJISx4051LineBreaker::Next at /Users/ireid/tbird/comm-central/mozilla/intl/lwbrk/src/nsJISx4501LineBreaker.cpp:785
#1	0x00000001036b9d9c in nsMsgComposeService::GetOrigWindowSelection(int, nsIMsgWindow*, nsACString_internal&) ()
#2	0x00000001036baba1 in nsMsgComposeService::OpenComposeWindow at /Users/ireid/tbird/comm-central/mailnews/compose/src/nsMsgComposeService.cpp:549


We try to get the selected text for the current message view; when no text is selected, we get a valid select object at around http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgComposeService.cpp#431 but then pass a zero-length string (and zero for length and position) to lineBreaker->Next() at http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgComposeService.cpp#454

The composer seems to do the right thing in the end, bringing up a compose window quoting the entire text of the replied-to message, but it would be better to do that without triggering an assertion failure.

Comment 1

[Magnus Melin [:mkmelin]]

Fixed by bug 827061
http://hg.mozilla.org/comm-central/rev/e63ea30fd18b