812624 - Validator incorrectly always uses DEFAULT_WEBAPP_MRKT_URLS from constants.py

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

1) https://github.com/mozilla/zamboni/blob/master/mkt/developers/tasks.py#L119
`validate_app` is called with `market_urls=settings.VALIDATOR_IAF_URLS`.

2) https://github.com/mozilla/app-validator/blob/master/appvalidator/validate.py#L80
`market_urls` are used to set `constants.DEFAULT_WEBAPP_MRKT_URLS`

3) https://github.com/mozilla/app-validator/blob/master/appvalidator/specs/webapps.py#L6
`DEFAULT_WEBAPP_MRKT_URLS` is extracted from `..constants`, thereby replacing the `market_urls` set in the file above

We should avoid this code path, because currently https://github.com/mozilla/app-validator/blob/master/appvalidator/constants.py#L13 afaict is what's always being processed as the `DEFAULT_WEBAPP_MRKT_URLS`.

Comment 1

[Matt Basta [:basta]]

This should be fixed with the changes in the cleanup commit that also does CSP stuff:

https://github.com/mozilla/app-validator/commit/35d0d1e5a797b3927d1ccf6317d5a3f6a529f57c

RESOLVED FIXED(MAYBE(PROBABLY))

Comment 2

[Christopher Van Wiemeersch [:cvan]]

If I add VALIDATOR_IAF_URLS = ['https://marketplace.firefox.org'] to the local settings, the validator still allow me to upload manifests matching that.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #2)
> If I add VALIDATOR_IAF_URLS = ['https://marketplace.firefox.org'] to the
> local settings, the validator still allow me to upload manifests matching
> that.

*still does not allow

Comment 4

[Matt Basta [:basta]]

https://github.com/mozilla/app-validator/commit/f50f53649a1424952387f53016bee07062bed9e4