Closed Bug 812680 Opened 7 years ago Closed 6 years ago

Whitelist HTC One X for libstagefright decoding

Categories

(Core :: Audio/Video, defect, trivial)

ARM
Android
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: eflores, Assigned: cajbir)

References

Details

(Keywords: verifyme)

Attachments

(4 files, 4 obsolete files)

If you want to do this in the code (as opposed to doing it in the AMO blocklist; I don't know if the latter is possible, would require some analysis), the file to edit is: 

   widget/android/GfxInfo.cpp

Specifically in GfxInfo::GetFeatureStatusImpl, search for STAGEFRIGHT to see the existing code.

You will need to know how you plan to identify the phones that you want to whitelist. By model? hardware? manufacturer? product? All these fields are at your disposal (See e.g. Model()).
Status?
I've assigned to Edwin since he has an HTC One X that can test.
Assignee: nobody → edwin
Status: NEW → ASSIGNED
Taking this as Bug 860599 should fix it.
Assignee: edwin → chris.double
Depends on: 860599
Patches require fixes in bug 860599 to be landed. This removes the libomxplugin shared library that was specific to the HTC One X. It is no longer needed now that we don't use custom DataSource classes.
Needs bug 860599 to allow HTC One X to work without workarounds.
Attachment #769540 - Attachment is obsolete: true
Attachment #797047 - Flags: review?(edwin)
Attachment #769541 - Attachment is obsolete: true
Attachment #797048 - Flags: review?(mark.finkle)
Attachment #769542 - Attachment is obsolete: true
Attachment #797049 - Flags: review?(khuey)
Attachment #769543 - Attachment is obsolete: true
Attachment #797050 - Flags: review?(bjacob)
Attachment #797048 - Flags: review?(mark.finkle) → review+
Attachment #797050 - Flags: review?(bjacob) → review+
Comment on attachment 797047 [details] [diff] [review]
Part 1: Remove OMX media plugin workarounds for HTC One X

Review of attachment 797047 [details] [diff] [review]:
-----------------------------------------------------------------

Ka-pow!
Attachment #797047 - Flags: review?(edwin) → review+
Flags: needinfo?(kbrosnan)
Keywords: verifyme
The HTC One X+ was flashed to Cynanogen mod. I spent a while trying some things to flash it back to stock. So far no luck.
Flags: needinfo?(kbrosnan)
You need to log in before you can comment on or make changes to this bug.