Closed
Bug 812680
Opened 13 years ago
Closed 12 years ago
Whitelist HTC One X for libstagefright decoding
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: eflores, Assigned: cajbir)
References
Details
(Keywords: verifyme)
Attachments
(4 files, 4 obsolete files)
|
4.33 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
|
1.01 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
|
2.00 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
|
973 bytes,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
Works on my device
|
||
Comment 1•13 years ago
|
||
If you want to do this in the code (as opposed to doing it in the AMO blocklist; I don't know if the latter is possible, would require some analysis), the file to edit is:
widget/android/GfxInfo.cpp
Specifically in GfxInfo::GetFeatureStatusImpl, search for STAGEFRIGHT to see the existing code.
You will need to know how you plan to identify the phones that you want to whitelist. By model? hardware? manufacturer? product? All these fields are at your disposal (See e.g. Model()).
|
||
Comment 2•12 years ago
|
||
Status?
|
Assignee | |
Comment 3•12 years ago
|
||
I've assigned to Edwin since he has an HTC One X that can test.
Assignee: nobody → edwin
|
|
||
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•12 years ago
|
||
Taking this as Bug 860599 should fix it.
Assignee: edwin → chris.double
Depends on: 860599
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
|
Assignee | |
Comment 8•12 years ago
|
||
Patches require fixes in bug 860599 to be landed. This removes the libomxplugin shared library that was specific to the HTC One X. It is no longer needed now that we don't use custom DataSource classes.
|
|
Assignee | |
Comment 9•12 years ago
|
||
Needs bug 860599 to allow HTC One X to work without workarounds.
Attachment #769540 -
Attachment is obsolete: true
Attachment #797047 -
Flags: review?(edwin)
|
|
Assignee | |
Comment 10•12 years ago
|
||
Attachment #769541 -
Attachment is obsolete: true
Attachment #797048 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 11•12 years ago
|
||
Attachment #769542 -
Attachment is obsolete: true
Attachment #797049 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 12•12 years ago
|
||
Attachment #769543 -
Attachment is obsolete: true
Attachment #797050 -
Flags: review?(bjacob)
|
||
Updated•12 years ago
|
Attachment #797048 -
Flags: review?(mark.finkle) → review+
|
|
||
Updated•12 years ago
|
Attachment #797050 -
Flags: review?(bjacob) → review+
|
Reporter | |
Comment 13•12 years ago
|
||
Comment on attachment 797047 [details] [diff] [review]
Part 1: Remove OMX media plugin workarounds for HTC One X
Review of attachment 797047 [details] [diff] [review]:
-----------------------------------------------------------------
Ka-pow!
Attachment #797047 -
Flags: review?(edwin) → review+
Attachment #797049 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 14•12 years ago
|
||
|
||
Comment 15•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/93d729e67e0a
https://hg.mozilla.org/mozilla-central/rev/9b35e8f27c5f
https://hg.mozilla.org/mozilla-central/rev/21e718994c5f
https://hg.mozilla.org/mozilla-central/rev/9cfedf557f71
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Comment 16•12 years ago
|
||
The HTC One X+ was flashed to Cynanogen mod. I spent a while trying some things to flash it back to stock. So far no luck.
Flags: needinfo?(kbrosnan)
You need to log in
before you can comment on or make changes to this bug.
Description
•