81269 - Investigate possible issues with recursive reflows

Status: VERIFIED DUPLICATE of bug 81268

(Core :: Layout, defect)

Description

[Marc Attinasi]

While investigating another problem, I put a check in nsFrame::WillReflow to
assert if the frame is already in a reflow. Strangely, this assert gets
triggered whenever I pop up a XUL-based dialog (preferences dialog in browser,
or table dialog in Composers, for example).

I cannot understand yet if we support recursive reflows in some cases, all
cases, or if this is a bug. The frame in question is always the ViewportFrame.
Here is the code I added:

NS_IMETHODIMP
nsFrame::WillReflow(nsIPresContext* aPresContext)
{
#ifdef DEBUG
  if (0 != (mState & NS_FRAME_IN_REFLOW)) {
    NS_ASSERTION(0 == (mState & NS_FRAME_IN_REFLOW),
                 "frame is already in reflow");
    nsresult rv = NS_OK;
  }
#endif

  NS_FRAME_TRACE_MSG(NS_FRAME_TRACE_CALLS,
                     ("WillReflow: oldState=%x", mState));
  mState |= NS_FRAME_IN_REFLOW;
  return NS_OK;
}


This bug is a reminder to investigate this...

Comment 1

[:deanis74]

entered twice

*** This bug has been marked as a duplicate of 81268 ***

Comment 2

[Alex Bishop]

Verified duplicate.