812701 - Drop the prefixed version of visibility API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We added support for the unprefixed version in bug 812086.  This bug is on dropping the prefixed version.

Comment 1

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/prefixed-page-visibility-api-will-be-removed/

Comment 2

[Thomas Wisniewski]

I only addons that I currently see on DXR which would have an issue with removing the prefixed version are:

https://dxr.mozilla.org/addons/source/648466 (Page Snap)
https://dxr.mozilla.org/addons/source/629290 (Ant Download Manager addon)
https://dxr.mozilla.org/addons/source/564134 (Watch Now)
https://dxr.mozilla.org/addons/source/515206 (Anticaptcha)
https://dxr.mozilla.org/addons/source/431482 (Easy Screenshot)
https://dxr.mozilla.org/addons/source/410914 (Firefox OS Simulator by Myk Melez)
https://dxr.mozilla.org/addons/source/261957 (Scrollbar Search Highlighter)

The only one marked as compatible with a recent version Firefox is Ant Download Manager at v47, with Easy Screenshot being the next-closest one at v40 (and the rest far behind).

As such, would any other telemetry (or outreach) be advisable before we drop the prefixed version?

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Having this bug flagged with addon-compat is enough in cases like this. We will include it in the compatibility communications for the version where it lands. Just make sure Target Milestone is set and we're good.

Comment 4

[Thomas Wisniewski]

Attachment: 812701-drop-the-prefixed-version-of-the-Visibility-API.diff

Alright, then here's a patch which removes support for the prefixed API (assuming we're alright with doing so now).

A try-run is fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb09a90e98d

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8788317 [details] [diff] [review]
812701-drop-the-prefixed-version-of-the-Visibility-API.diff

r=me, but please send an intent to ship?

Comment 6

[Thomas Wisniewski]

Of course, done: https://groups.google.com/forum/?_escaped_fragment_=topic/mozilla.dev.platform/FkAJkVOJF74

Comment 7

[Thomas Wisniewski]

Attachment: 812701-drop-the-prefixed-version-of-the-Visibility-API.diff

There haven't been any comments on dev.platform after a week, so I'm going to land this.

Here's a rebased patch. Carrying over r+ and requesting check-in.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f0df87ccf9c
Drop the prefixed version of the Visibility API. r=bz

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f0df87ccf9c

Comment 10

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/prefixed-page-visibility-api-has-been-removed/

Comment 11

[Jean-Yves Perrier [:teoli]]

Updated browser compat info in:
https://developer.mozilla.org/en-US/docs/Web/API/Page_Visibility_API
https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState
https://developer.mozilla.org/en-US/docs/Web/API/Document/hidden
and put a mention in:
https://developer.mozilla.org/en-US/Firefox/Releases/51#Others