Closed Bug 812701 Opened 12 years ago Closed 8 years ago

Drop the prefixed version of visibility API

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bzbarsky, Assigned: wisniewskit)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat, dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

We added support for the unprefixed version in bug 812086.  This bug is on dropping the prefixed version.
I only addons that I currently see on DXR which would have an issue with removing the prefixed version are:

https://dxr.mozilla.org/addons/source/648466 (Page Snap)
https://dxr.mozilla.org/addons/source/629290 (Ant Download Manager addon)
https://dxr.mozilla.org/addons/source/564134 (Watch Now)
https://dxr.mozilla.org/addons/source/515206 (Anticaptcha)
https://dxr.mozilla.org/addons/source/431482 (Easy Screenshot)
https://dxr.mozilla.org/addons/source/410914 (Firefox OS Simulator by Myk Melez)
https://dxr.mozilla.org/addons/source/261957 (Scrollbar Search Highlighter)

The only one marked as compatible with a recent version Firefox is Ant Download Manager at v47, with Easy Screenshot being the next-closest one at v40 (and the rest far behind).

As such, would any other telemetry (or outreach) be advisable before we drop the prefixed version?
Flags: needinfo?(jorge)
Flags: needinfo?(bzbarsky)
Having this bug flagged with addon-compat is enough in cases like this. We will include it in the compatibility communications for the version where it lands. Just make sure Target Milestone is set and we're good.
Flags: needinfo?(jorge)
Flags: needinfo?(bzbarsky)
Alright, then here's a patch which removes support for the prefixed API (assuming we're alright with doing so now).

A try-run is fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb09a90e98d
Attachment #8788317 - Flags: review?(bzbarsky)
Comment on attachment 8788317 [details] [diff] [review]
812701-drop-the-prefixed-version-of-the-Visibility-API.diff

r=me, but please send an intent to ship?
Attachment #8788317 - Flags: review?(bzbarsky) → review+
There haven't been any comments on dev.platform after a week, so I'm going to land this.

Here's a rebased patch. Carrying over r+ and requesting check-in.
Assignee: nobody → wisniewskit
Attachment #8788317 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f0df87ccf9c
Drop the prefixed version of the Visibility API. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8f0df87ccf9c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.