Closed
Bug 812716
Opened 12 years ago
Closed 12 years ago
Desktop Notifications: Race in nsDOMDesktopNotification constructor
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
People
(Reporter: gwagner, Assigned: mrbkap)
Details
Attachments
(1 file)
3.74 KB,
patch
|
dougt
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
mrbkap found a race condition when we create the desktop notification object.
Reporter | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mrbkap
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 682707 [details] [diff] [review] patch I'm not sure that this can actually race, but the early return in the if (!GetOwner()) case can definitely cause crashes. It's pretty hairy to reference count an object in its constructor, so this seems a lot saner in general.
Attachment #682707 -
Flags: review?(doug.turner)
Updated•12 years ago
|
Attachment #682707 -
Flags: review?(doug.turner) → review+
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Reporter | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2d2e78a956
Assignee | ||
Comment 4•12 years ago
|
||
Note to blocking-basecamp triagers: this is a very low-risk correctness bug that could prevent child-process crashes in certain edge cases.
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9e2d2e78a956
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 6•12 years ago
|
||
basecamp- but please nom for beta if this is really low risk.
blocking-basecamp: ? → -
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 682707 [details] [diff] [review] patch [Approval Request Comment] User impact if declined: In certain rare cases, content processes could crash when sending desktop notifications. Testing completed (on m-c, etc.): This has been on m-c for a few days. This patch is extremely low-risk, and is easily provably correct via code inspection.
Attachment #682707 -
Flags: approval-mozilla-beta?
Comment 8•12 years ago
|
||
Comment on attachment 682707 [details] [diff] [review] patch [Triage Comment] Very low risk fix that may resolve some B2G instability. Approving for branches.
Attachment #682707 -
Flags: approval-mozilla-beta?
Attachment #682707 -
Flags: approval-mozilla-beta+
Attachment #682707 -
Flags: approval-mozilla-aurora+
Comment 9•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d75a9dd5b181 https://hg.mozilla.org/releases/mozilla-beta/rev/076e16981f2f
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•