Closed
Bug 812824
Opened 13 years ago
Closed 13 years ago
"ABORT: Should be tracking any images we're going to use"
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jruderman, Assigned: khuey)
References
Details
(Keywords: assertion, testcase)
Attachments
(4 files, 1 obsolete file)
###!!! ABORT: Should be tracking any images we're going to use!: '!mBorderImageSource || mImageTracked', file nsStyleStructInlines.h, line 30
Not sure why the testcase requires the stylesheet to come after the div.
|
Reporter | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Presumably to trigger a dynamic restyle?
So having parentdata_ == data_ when we're computing style for the root element (which always means parentdata_ == data_, since parentContext is null; see COMPUTE_START_RESET) with a non-null aStartStruct is basically bad news in general, since we then use the values from the start struct to 'inherit' from instead of using the initial values.
It seems like either we should:
* just not use start structs when computing data for the root element, or
* construct a parent data using the default constructor when we're dealing with the root (perhaps good in general and not only when we have a start struct)
|
Assignee | |
Comment 5•13 years ago
|
||
This is percolating through try. It does fix the attached testcases.
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #684260 -
Attachment is obsolete: true
Attachment #684424 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #684424 -
Flags: review?(jwalden+bmo)
Comment on attachment 684424 [details] [diff] [review]
Patch
>diff --git a/layout/reftests/bugs/812824-1-ref.html b/layout/reftests/bugs/812824-1-ref.html
>new file mode 100644
>--- /dev/null
>+++ b/layout/reftests/bugs/812824-1-ref.html
>@@ -0,0 +1,4 @@
>+<!DOCTYPE HTML>
>+<style> html { background-color: red } </style>
>+<style> html { background-color: inherit } </style>
>+<p>This document should NOT have a red background.</p>
I'd say remove the "background-color: red" line from the ref as well.
>+ nsStyleContext* parentContext = aContext->GetParent();
Just use the parentContext variable you already have.
with that, r=dbaron on the layout/ changes
Attachment #684424 -
Flags: review?(dbaron) → review+
|
||
Comment 8•13 years ago
|
||
Comment on attachment 684424 [details] [diff] [review]
Patch
Review of attachment 684424 [details] [diff] [review]:
-----------------------------------------------------------------
r=me on the Util.h bit, I assume you don't want me for the rest. :-)
Attachment #684424 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
Target Milestone: --- → mozilla20
|
||
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•