Closed
Bug 812932
Opened 12 years ago
Closed 12 years ago
ICO files cannot be decoded on (at least some) big endian machines
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: tobias.netzel, Assigned: tobias.netzel)
Details
Attachments
(1 file, 1 obsolete file)
493 bytes,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-us) AppleWebKit/534.50.2 (KHTML, like Gecko) (like Version/6.0 Safari/534.50.2) Roccat/2.8 Roccat/534.50.2
Steps to reproduce:
a) Visit a web site with ICO favicon.
b) Load a ICO file directly into the browser
Actual results:
a) Icon doesn't display
b) "The image "{file path}" cannot be displayed because it contains errors
Expected results:
The image should have been decoded and displayed correctly.
Assignee | ||
Updated•12 years ago
|
Hardware: x86 → PowerPC
Assignee | ||
Comment 1•12 years ago
|
||
ICO files cannot be decoded because image/src/EndianMacros.h doesn't recognize big endian architecture if nspr headers aren't included first, at least when building with gcc (version 4.7.2 in this case) on PowerPC Mac OS X.
Summary: ICO files cannot be decoded because image/src/EndianMacros.h doesn't recognize big endian architecture if nspr headers aren't included first, at least when building with gcc → ICO files cannot be decoded on (at least some) big endian machines
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #682947 -
Attachment is obsolete: true
Updated•12 years ago
|
Attachment #682948 -
Flags: review?(netzen)
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•12 years ago
|
||
Comment on attachment 682948 [details] [diff] [review]
Have EndianMacros.h recognize __BIG_ENDIAN__ preprocessor macro
Looks good, thanks for the patch
Attachment #682948 -
Flags: review?(netzen) → review+
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Assignee: nobody → tobias.netzel
Status: NEW → ASSIGNED
Updated•12 years ago
|
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•