812932 - ICO files cannot be decoded on (at least some) big endian machines

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Tobias Netzel]

Attachment: Patch against EndianMacros.h

User Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-us) AppleWebKit/534.50.2 (KHTML, like Gecko) (like Version/6.0 Safari/534.50.2) Roccat/2.8 Roccat/534.50.2

Steps to reproduce:

a) Visit a web site with ICO favicon.
b) Load a ICO file directly into the browser


Actual results:

a) Icon doesn't display
b) "The image "{file path}" cannot be displayed because it contains errors


Expected results:

The image should have been decoded and displayed correctly.

Comment 1

[Tobias Netzel]

ICO files cannot be decoded because image/src/EndianMacros.h doesn't recognize big endian architecture if nspr headers aren't included first, at least when building with gcc (version 4.7.2 in this case) on PowerPC Mac OS X.

Comment 2

[Tobias Netzel]

Attachment: Have EndianMacros.h recognize __BIG_ENDIAN__ preprocessor macro

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 682948 [details] [diff] [review]
Have EndianMacros.h recognize __BIG_ENDIAN__ preprocessor macro

Looks good, thanks for the patch

Comment 4

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1326ff4b3398

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1326ff4b3398