812935 - Undefined value error in memory reporter for web workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nicholas Nethercote [inactive]]

I was getting a failure in test_memoryReporters.xul because the "explicit" 
single reporter was usually (but not always) returning absurdly large values.

The problem is in the "Unable to report memory for Worker..." case in
CollectForRuntime().  It returns NS_OK but fails to set |aData|.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Fix undefined value error in memory reporter for web workers.

This simple patch just sets |aData| to zero in this case.  It fixes the test failure.

Comment 2

[Nicholas Nethercote [inactive]]

I think this goes back to bug 749010, which landed in Firefox 13.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77c8bc0e550a

Thanks for the quick stolen review, khuey.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 682951 [details] [diff] [review]
Fix undefined value error in memory reporter for web workers.

[Approval Request Comment]

Bug caused by (feature/regressing bug #): bug 749010 (in Firefox 13).

User impact if declined: The "explicit" number at the bottom of about:memory (and in telemetry) can be ridiculously large when certain kinds of web workers are used.

Testing completed (on m-c, etc.):  Just landed on mozilla-inbound.

Risk to taking this patch (and alternatives if risky):  It's a trivial, one-line change.

String or UUID changes made by this patch:  None.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 682951 [details] [diff] [review]
Fix undefined value error in memory reporter for web workers.

[Triage Comment]
Low risk fix in support of better Telemetry data. Approving for FF18.

If this is landed on mozilla-aurora before ~11AM PT tomorrow, this will make the merge from Aurora 18 to Beta 18. If landed 11AM-5PM PT tomorrow on mozilla-beta, it will make the first FF18 Beta. If landed after that, it will end up in the second FF18 beta.

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b51e664d7036

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/77c8bc0e550a

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/77c8bc0e550a
> 
> Thanks for the quick stolen review, khuey.

Trying to log into Bugzilla on my phone to do that was fun.