812942 - "HTML5 Extension for Windows Media Player Firefox Plug-in" is no longer working after landing Bug 788914

Status: RESOLVED WORKSFORME

(Core :: XPConnect, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/b959971b8219
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0 ID:20121118030713

See: http://forums.mozillazine.org/viewtopic.php?f=23&t=2619233

Steps to reproduce:
1. Install  "Windows Media Player Firefox Plugin"( http://www.interoperabilitybridges.com/windows-media-player-firefox-plugin-download )
2. Install "HTML5 Extension for Windows Media Player Firefox Plug-in"( http://www.interoperabilitybridges.com/html5-extension-for-wmp-plugin )
3. Restart browser
4. Open http://ie.microsoft.com/testdrive/Graphics/VideoFormatSupport/Default.html

Actual results:
"Your browser cannot play H.264 high profile/baseline content with the HTML5 video element.
The video could not be loaded, either because the server or network failed or because the format is not supported."

Expected results:
Embedded "Windows Media Player Firefox Plugin" appears


Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/96287ad60bef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120910183953
Bad:
http://hg.mozilla.org/mozilla-central/rev/d042ad078f43
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120911065552
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=96287ad60bef&tochange=d042ad078f43

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c8e5053af5ad
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120911004454
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4f5b4f0ecf01
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120911010554
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c8e5053af5ad&tochange=4f5b4f0ecf01

Triggered by:Bug 788914

Comment 1

[Alice0775 White]

Error console shows error as follows:

Error: The Components object is deprecated. It will soon be removed.
Source file: resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/cuddlefish.js -> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/sandbox.js -> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/data/content-proxy.js
Line: 7
 ----------
Error: Exposing chrome JS objects to content without __exposedProps__ is insecure and deprecated. See https://developer.mozilla.org/en/XPConnect_wrappers for more information.
Source file: resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/cuddlefish.js -> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/sandbox.js -> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/data/worker.js
Line: 126
 ----------
Error: An exception occurred.
Traceback (most recent call last):
[object Object]

Comment 2

[Bobby Holley (:bholley)]

(In reply to Alice0775 White from comment #1)
> Error console shows error as follows:
> 
> Error: The Components object is deprecated. It will soon be removed.
> Source file:
> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/
> cuddlefish.js ->
> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/sandbox.
> js ->
> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/data/
> content-proxy.js
> Line: 7
>  ----------
> Error: Exposing chrome JS objects to content without __exposedProps__ is
> insecure and deprecated. See
> https://developer.mozilla.org/en/XPConnect_wrappers for more information.
> Source file:
> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/
> cuddlefish.js ->
> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/lib/sandbox.
> js ->
> resource://jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack/api-utils/data/worker.
> js
> Line: 126
>  ----------

These appear to be coming from the bugzilla tweak addon unless I'm mistaken, so I don't think they're relevant here.

Comment 3

[Alice0775 White]

(In reply to Bobby Holley (:bholley) from comment #2)

> 
> These appear to be coming from the bugzilla tweak addon unless I'm mistaken,
> so I don't think they're relevant here.

I do no install the bugzilla tweak addon.
See STR in Comment #0. Pls read STR carefully.
I installed one plug-in and one addon each.

Comment 4

[Bobby Holley (:bholley)]

(In reply to Alice0775 White from comment #3)
> (In reply to Bobby Holley (:bholley) from comment #2)
> 
> > 
> > These appear to be coming from the bugzilla tweak addon unless I'm mistaken,
> > so I don't think they're relevant here.
> 
> I do no install the bugzilla tweak addon.

Sorry, my mistake from skimming the google results for |jid0-nrwp7vvcqzcsrtppwwz2npqgekw-at-jetpack| too quickly. It appears to be coming from the jetpack SDK itself. But again, probably not relevant to the bug at hand.

Anyway, my guess here is that the plugin code here was relying on security checks being skipped when there's no JS code on the stack. This only worked accidentally before, and is something we no longer support.

Given that fixing this probably requires changing the plugin, and given that the plugin is windows-only and closed-source, I'm pretty reluctant to spend time digging into it. If someone wants to get in touch with the developers and point them to this bug, I'm happy to help them out debugging, explain what's going on, and offer potential solutions.

Regardless, I'm incredibly grateful for your tireless work hunting down bugs, generating regression ranges, and figuring out STRs, Alice. I (and everyone else I know at Mozilla) greatly appreciate everything you do. :-)

Comment 5

[MrX1980]

Hi, I have contacted already yesterday the "Interoperability / Microsoft" team via "Contact Us" and today again with this bug code.
I hope they will react.

Info: Step 1 is not needed in STR

Thank you Alice for this bug entry.
It is based on:
http://forums.mozillazine.org/viewtopic.php?f=23&t=2619233

Comment 6

[Bobby Holley (:bholley)]

It's possible that this might be fixed by the patch in bug 812415, since both regressions came from the same set of patches. If someone who can easily reproduce this bug wants to, it might be worth seeing if that patch fixes it.

Comment 7

[Alice0775 White]

(In reply to Bobby Holley (:bholley) from comment #6)
> It's possible that this might be fixed by the patch in bug 812415, since
> both regressions came from the same set of patches. If someone who can
> easily reproduce this bug wants to, it might be worth seeing if that patch
> fixes it.

I confirmed in local build that the patch attachment 683750 [details] [diff] [review] of bug 812415 fixes this problem :).

Comment 8

[Bobby Holley (:bholley)]

(In reply to Alice0775 White from comment #7)
> I confirmed in local build that the patch attachment 683750 [details] [diff] [review]
> [review] of bug 812415 fixes this problem :).

Hooray! Sorry for that one - stupid bug on my part.

Comment 9

[Alex Keybl [:akeybl]]

Already tracking bug 812415 for release, so no need to track this bug.

Comment 10

[Phoenix]

WFM in current FF21 beta, closing
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0