812946 - Mix C++ and JS backtraces on Linux x86/x64.

Status: RESOLVED WORKSFORME

(Core :: Gecko Profiler, defect)

Description

[Nicolas B. Pierron [:nbp]]

The current implementation of the gecko profiler does not support mixing backtraces for C++ and JS in a profile.  The current implementation iterate on the C++ stack with the backtrace function which does not provide the frame pointer of each frame.

Mac implementation is using pthread_get_stackaddr_np, which can be translated with pthread_getattr_np on Linux.

This bug is a short-term fix as breakpad is supposed to replace this stack walking implementation in a long-term.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Use stackwalking on Linux.

This is not urgent, not tested on tbpl, and is unlikely to fit all expectation.

This is just a not-so dirty version of my hacky patch to mix the C++ stack with the JS stack.  When testing with a browser or a few shell benchmarks, I saw a few hangs which might be related to Bug 757186.  In the mean time I provide this patch because it is still useful for profiling in the xpcshell no matters if there is a hang or not.

Comment 2

[Nicolas B. Pierron [:nbp]]

Unassigned my-self: I am not actively work on it.
And it seems to work, so maybe mark this bug as a duplicate of something else ?!

Comment 3

[Benoit Girard (:BenWa)]

This has been fixed elsewhere.