813030 - [contacts] [gallery] Not able to add a photo from gallery to a contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested with unagi with:

gaia 620399e
gecko 85d0121

STR:
1-Open contacts app
2-Create a new contact
3-Tap in the + symbol to add a photo
4-Select add from gallery

Expected result --> You can select the photo, crop it if needed and finally add it to the contact

Actul result --> Gallery app is crashing

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

David, is this a regression from bug 794407 ?

Comment 2

[Mounir Lamouri (:mounir)]

What does `adb logcat` says?

Comment 3

[diana.garcia]

Actul result --> Gallery app is crashing and the device restarts the first two times.  After I can select the photo properly.

Comment 4

[alberto.pastor]

I'm getting a NO_PROVIDER DOMError in logcat with last gecko/gaia. Not sure it was the initial bug, but that's the current result.

Comment 5

[Mounir Lamouri (:mounir)]

Andread, could you check if the issue in comment 4 doesn't come from your patch?

Comment 6

[Andrea Marchesini [:baku]]

https://github.com/mozilla-b2g/gaia/pull/6578

Comment 7

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 8

[Mounir Lamouri (:mounir)]

Comment on attachment 684388 [details] [diff] [review]
patch

Review of attachment 684388 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a Gaia peer.

Comment 9

[Andrea Marchesini [:baku]]

This bug is a duplicate of 813462 but I would like to see this patch landed as well becuase there are no reasons to have width/height in the activity: the image is resize at 'onsuccess' in any case.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/992e8783b440597ad9aecd505806f163ffea89ea

It seems like this is also hard to create sms from the contact edition page since your changes? Do you mind having a look?

Comment 11

[Andrea Marchesini [:baku]]

I already submitted a patch for that.

Comment 12

[alberto.pastor]

(In reply to Andrea Marchesini (:baku) from comment #9)
> This bug is a duplicate of 813462 but I would like to see this patch landed
> as well becuase there are no reasons to have width/height in the activity:
> the image is resize at 'onsuccess' in any case.

As far as I know, the size is used by the gallery for cropping. Is resized in the onsuccess because the Camera is not allowing to crop after taking the picture.

Comment 13

[David Flanagan [:djf]]

Please revert the patch from this bug. The width and height properties allow the gallery to provide an image of the correct size. And more importantly, they tell the gallery what the desired aspect ratio of the image is, and affect the way it does cropping.  Without those parameters, the gallery would allow the user to crop the image at any aspect ratio, even though the contacts app really wants a square image.

Comment 14

[David Scravaglieri [:scravag]]

Not a smoketest blocker anymore.

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/575c3716a0de243adb7ebce1ecd2e21a63f00703

Comment 16

[Deepa Subramanian]

verified on unagi build id:  20130103070201