Closed Bug 813031 Opened 10 years ago Closed 10 years ago
Dev Tools needs an API review [toolbox]
We noticed 2 things while creating gDevTools: - the ``isReady | once("ready")`` thing could be better through use of promises - toggleToolboxCommand should be moved off gDevTools
Summary: gDevTools needs an API review. → gDevTools needs an API review [toolbox]
From https://github.com/joewalker/devtools-window/issues/108#issuecomment-11037780 > We might need to cleanup a bit Toolbox. For example, we expose frame and doc. I don't think we need these properties. > (by exposing, I mean not prefixing the property with _)
what was "landed" in fx-team?
Assignee: nobody → jwalker
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Review took place here: https://github.com/joewalker/devtools-window/pull/324
Just in case somebody else is trying to figure out when these API changes took place: they landed with http://hg.mozilla.org/mozilla-central/rev/fea63da9e80c and were released with Firefox 20 if my calculations are correct.
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.