gDevTools needs an API review [toolbox]

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Developer Tools
P1
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We noticed 2 things while creating gDevTools:
- the ``isReady | once("ready")`` thing could be better through use of promises
- toggleToolboxCommand should be moved off gDevTools
Summary: gDevTools needs an API review. → gDevTools needs an API review [toolbox]

Updated

6 years ago
Blocks: 788977

Updated

6 years ago
Blocks: 817565

Comment 1

5 years ago
From https://github.com/joewalker/devtools-window/issues/108#issuecomment-11037780

> We might need to cleanup a bit Toolbox. For example, we expose frame and doc. I don't think we need these properties.
> (by exposing, I mean not prefixing the property with _)

Updated

5 years ago
No longer blocks: 788977

Updated

5 years ago
Blocks: 816946

Updated

5 years ago
Blocks: 815239

Updated

5 years ago
Priority: -- → P1
Whiteboard: [landed-in-fx-team]
what was "landed" in fx-team?
Created attachment 692270 [details] [diff] [review]
as pushed
Assignee: nobody → jwalker
https://tbpl.mozilla.org/?rev=8a30e07815ff
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fx-team]

Updated

5 years ago
Depends on: 821802
Depends on: 822097

Updated

5 years ago
Attachment #692270 - Flags: review+

Updated

5 years ago
Depends on: 824070

Comment 6

4 years ago
Just in case somebody else is trying to figure out when these API changes took place: they landed with http://hg.mozilla.org/mozilla-central/rev/fea63da9e80c and were released with Firefox 20 if my calculations are correct.
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.