Closed
Bug 813031
Opened 12 years ago
Closed 12 years ago
gDevTools needs an API review [toolbox]
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
Attachments
(1 file)
|
179.50 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
We noticed 2 things while creating gDevTools:
- the ``isReady | once("ready")`` thing could be better through use of promises
- toggleToolboxCommand should be moved off gDevTools
|
Assignee | |
Updated•12 years ago
|
Summary: gDevTools needs an API review. → gDevTools needs an API review [toolbox]
|
||
Comment 1•12 years ago
|
||
From https://github.com/joewalker/devtools-window/issues/108#issuecomment-11037780
> We might need to cleanup a bit Toolbox. For example, we expose frame and doc. I don't think we need these properties.
> (by exposing, I mean not prefixing the property with _)
|
|
||
Updated•12 years ago
|
Priority: -- → P1
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [landed-in-fx-team]
|
||
Comment 2•12 years ago
|
||
what was "landed" in fx-team?
|
|
Assignee | |
Comment 3•12 years ago
|
||
Assignee: nobody → jwalker
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fx-team]
|
|
Assignee | |
Comment 5•12 years ago
|
||
Review took place here: https://github.com/joewalker/devtools-window/pull/324
|
|
||
Updated•12 years ago
|
Attachment #692270 -
Flags: review+
|
||
Comment 6•11 years ago
|
||
Just in case somebody else is trying to figure out when these API changes took place: they landed with http://hg.mozilla.org/mozilla-central/rev/fea63da9e80c and were released with Firefox 20 if my calculations are correct.
Target Milestone: --- → Firefox 20
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•