Closed Bug 813031 Opened 8 years ago Closed 8 years ago

gDevTools needs an API review [toolbox]

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

Attachments

(1 file)

We noticed 2 things while creating gDevTools:
- the ``isReady | once("ready")`` thing could be better through use of promises
- toggleToolboxCommand should be moved off gDevTools
Summary: gDevTools needs an API review. → gDevTools needs an API review [toolbox]
Blocks: 788977
Blocks: 817565
From https://github.com/joewalker/devtools-window/issues/108#issuecomment-11037780

> We might need to cleanup a bit Toolbox. For example, we expose frame and doc. I don't think we need these properties.
> (by exposing, I mean not prefixing the property with _)
No longer blocks: 788977
Blocks: 816946
Blocks: 815239
Priority: -- → P1
Whiteboard: [landed-in-fx-team]
what was "landed" in fx-team?
Attached patch as pushedSplinter Review
Assignee: nobody → jwalker
https://tbpl.mozilla.org/?rev=8a30e07815ff
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fx-team]
Depends on: 821802
Depends on: 822097
Attachment #692270 - Flags: review+
Depends on: 824070
Just in case somebody else is trying to figure out when these API changes took place: they landed with http://hg.mozilla.org/mozilla-central/rev/fea63da9e80c and were released with Firefox 20 if my calculations are correct.
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.