Tapping on Clock does not take user to clock app.

RESOLVED WORKSFORME

Status

Firefox OS
Gaia::Homescreen
RESOLVED WORKSFORME
6 years ago
4 years ago

People

(Reporter: pabloUX, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: interaction)

Attachments

(1 attachment, 2 obsolete attachments)

188 bytes, text/html
vingtetun
: review-
Details
(Reporter)

Description

6 years ago
* Environment: Unagi, build (dev) from Friday 16 Nov.
* Repro: Browse to landing page, tap on clock. Nothing happens.
* Expected: Tapping on clock in landing page will invoke the Clock app.
* Actual: Nothing happens. User stays in landing page.
Whiteboard: Interaction design
(Assignee)

Updated

6 years ago
Assignee: nobody → crdlc
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 1

6 years ago
Created attachment 684370 [details]
Patch v1
Attachment #684370 - Flags: review?(21)
I'm not convinced that it should. We don't support widgets in v1, and don't want to train users to expect them in this or future releases. Clock app is not so vital that it needs a huge access shortcut. cc'ing Ricardo for input.
Summary: [Home/IxD]: Tapping on Clock does not take user to clock app. → Tapping on Clock does not take user to clock app.
Whiteboard: Interaction design → interaction
(Assignee)

Updated

5 years ago
Duplicate of this bug: 821223
Comment on attachment 684370 [details]
Patch v1

Removing review until a UX decision has been taken.
Attachment #684370 - Flags: review?(21)

Comment 5

5 years ago
Just talked with Josh and agreed to go ahead and make the clock area in landing page clickable. Please Vivien, Cristian, go ahead with submission and revision.

Thank you guys!

Ricardo
(Assignee)

Updated

5 years ago
Attachment #684370 - Flags: review?(21)
(Assignee)

Comment 6

5 years ago
I've tested the pull request and it continues working :)
Comment on attachment 684370 [details]
Patch v1

I really feel uncomfortable with hardcoding the clock application url in the homescreen application. If the user install a new clock he will never we able to access it with this link. That does not sounds right.
Attachment #684370 - Flags: review?(21) → review-
(Assignee)

Comment 8

5 years ago
I don't like that but that appears in master. Well, How could we do it? Implementing an activity in the clock app?

"activities": {
    "view": {
      "filters": {
        "type": "time"
      }
    }
(Assignee)

Comment 9

5 years ago
Created attachment 700365 [details]
Patch v2
Attachment #684370 - Attachment is obsolete: true
Attachment #700365 - Flags: review?(21)
(Assignee)

Comment 10

5 years ago
Created attachment 700367 [details]
Patch v3
Attachment #700365 - Attachment is obsolete: true
Attachment #700365 - Flags: review?(21)
Attachment #700367 - Flags: review?(21)
(In reply to crdlc from comment #8)
> I don't like that but that appears in master. Well, How could we do it?
> Implementing an activity in the clock app?
> 
> "activities": {
>     "view": {
>       "filters": {
>         "type": "time"
>       }
>     }

I'm like you I don't like to have to do an activity for such things...
(Assignee)

Comment 12

5 years ago
sorry but I don't have more ideas :)

1) No hardcoded, I agree that was a shit :) jejjeje
2) As activity...

Do you have any suggestion to run the clock app?

Thanks
(Assignee)

Comment 13

5 years ago
Did you forget this pr? :)
Flags: needinfo?(21)
Comment on attachment 700367 [details]
Patch v3

I still think this is the wrong way to do it but I don't have any good suggestions.
Attachment #700367 - Flags: review?(21) → review-
Flags: needinfo?(21)
(Assignee)

Comment 15

5 years ago
While we think about it, we could open other bug in order to fix this:

[JavaScript Error: "ReferenceError: Applications is not defined" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 3}]

So we could remove from

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.js#L27

to 

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.js#L33

Are you agree?
Flags: needinfo?(21)
(In reply to crdlc from comment #15)
> While we think about it, we could open other bug in order to fix this:
> 
> [JavaScript Error: "ReferenceError: Applications is not defined" {file:
> "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 3}]
> 
> So we could remove from
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.
> js#L27
> 
> to 
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.
> js#L33
> 
> Are you agree?

Sure. That sounds good to me.
Flags: needinfo?(21)
(Assignee)

Comment 17

4 years ago
It doesn't make sense anymore
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.