Closed Bug 813199 Opened 12 years ago Closed 12 years ago

Closing a tab with a conditional breakpoint panel open does not hide the panel

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox19 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 20
Tracking Flags:
Tracking Status
firefox19 --- fixed

People

(Reporter: vporof, Assigned: vporof)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

v1
1.46 KB, patch
past
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
Attached patch v1 — — Splinter Review 

        Attachment #683175 -
        Flags: review?(past)

    
  
Summary: Closing a tab with the a conditional breakpoint panel open does not hide the panel → Closing a tab with a conditional breakpoint panel open does not hide the panel

        Attachment #683175 -
        Flags: review?(past) → review+

    
  
Whiteboard: [land-in-fx-team]

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/f502b87db36a
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f502b87db36a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20

    
    

    
  
Comment on attachment 683175 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Users who are in the process of adding a conditional breakpoint and abruptly close the tab would still find a doorhanger panel open.
User impact if declined: Almost none, this patch affects a developer tool.
Testing completed (on m-c, etc.): fx-team and m-c
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

        Attachment #683175 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 683175 [details] [diff] [review]
v1

[Triage Comment]
Low risk fix for a new dev feature. Approving for Aurora 19.

        Attachment #683175 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  

          status-firefox19:
          --- → fixed

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: