813207 - Malformed license-header comment-block causes panel to look odd on gnomestripe

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Not sure how this slipped by, but the license header in downloads.css for gnomestripe had it's opening slash cut off, which is corrupting the first rule, and making it be ignored.

This makes the panel look rather strange on gnomestripe - I'll attach a screenshot in a second.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Funny looking panel on gnomestripe

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fix

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Thanks - landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/cc4e72937aaa

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hm - this didn't make the uplift, I don't think.

Marco - do you have any objections for me requesting aurora approval on this?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hm - this didn't make the uplift, I don't think.

Marco - do you have any objections for me requesting aurora approval on this?

Comment 6

[Marco Bonardo [:mak]]

no, we should indeed ask for it, the risk is limited and we need proper theming if we want decent feedback from Aurora users

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 683198 [details] [diff] [review]
Fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 811076

User impact if declined:
Funky styling of the Downloads Panel for Aurora users on gnomestripe.

Testing completed (on m-c, etc.):
All local testing.

Risk to taking this patch (and alternatives if risky):
No risk - the patch is trivial - just fixes a license header that I accidentally fat-fingered.

String or UUID changes made by this patch:
None.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cc4e72937aaa

Comment 9

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5fd2110fd5d6

Comment 10

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly and Aurora - the downloads panel looks properly on Ubuntu 12.04.

Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20.0 Firefox/20.0 Build ID: 20121128030742
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/20121128 Firefox/19.0 Build ID: 
20121128042014