Refactor MediaResource into CommonMediaResource so that we can base the implementation of BufferMediaResource on top of MediaResource

RESOLVED FIXED in mozilla20

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.30 KB, patch
cpearce
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Created attachment 683194 [details] [diff] [review]
Patch (v1)

I need this refactoring in order to make it possible to implement BufferMediaResource which represents a media resource sitting in a memory buffer.
Attachment #683194 - Flags: review?(cpearce)
Comment on attachment 683194 [details] [diff] [review]
Patch (v1)

Review of attachment 683194 [details] [diff] [review]:
-----------------------------------------------------------------

s/CommonMediaResource/BaseMediaResource/
Attachment #683194 - Flags: review?(cpearce) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f76720054116
Assignee: nobody → ehsan
(Assignee)

Comment 3

6 years ago
Backed out because of leaks: https://hg.mozilla.org/integration/mozilla-inbound/rev/da5c7437f563

I suspect the leaks might be happening because I'm counting the wrong ctor/dtor...
(Assignee)

Comment 4

6 years ago
Created attachment 683336 [details] [diff] [review]
Patch (v2)

Yep, this fixes the leaks.
Attachment #683194 - Attachment is obsolete: true
Attachment #683336 - Flags: review?(cpearce)
Attachment #683336 - Flags: review?(cpearce) → review+
What's BufferMediaSource/MediaSource in the bug summary? Did you mean BufferMediaResource/MediaResource?

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/d83f74d3768a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
(Assignee)

Comment 8

6 years ago
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> What's BufferMediaSource/MediaSource in the bug summary? Did you mean
> BufferMediaResource/MediaResource?

Yes, sorry for the mistake.  The idea is that BufferMediaResource will be an implementation of MediaResource based on top of an in-memory buffer.
Summary: Refactor MediaResource into CommonMediaResource so that we can base the implementation of BufferMediaSource on top of MediaSource → Refactor MediaResource into CommonMediaResource so that we can base the implementation of BufferMediaResource on top of MediaResource
You need to log in before you can comment on or make changes to this bug.