Closed
Bug 813215
Opened 12 years ago
Closed 12 years ago
Port browser_354894.js to the per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: marioalv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
10.42 KB,
patch
|
ehsan.akhgari
:
review+
ehsan.akhgari
:
feedback+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/browser_354894.js
Updated•12 years ago
|
Assignee: nobody → andres
Updated•12 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•12 years ago
|
||
This test is currently failing on Birch, and it's one of the blockers of getting Birch tests green.
Updated•12 years ago
|
Assignee: andres → marioalv.mozilla
Assignee | ||
Comment 2•12 years ago
|
||
Hi. This patch is a Work In Progress patch. I don't have a Windows environment to test the Windows part of the patch, so our idea is to run the patch on the try server and see if everything works OK. As the test comments state: " * @note Mac only tests the new notifications, as restoring the last window is * not enabled on that platform (platform shim; the application is kept running * although there are no windows left)" we can not test the Windows part on a Mac because there's no way to open/close/open the mochitest browser on a Mac, and this a is necessary step to do on this test.
Attachment #686447 -
Flags: review?(ehsan)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 686447 [details] [diff] [review] Patch to migrate the test to the new per window private mode Review of attachment 686447 [details] [diff] [review]: ----------------------------------------------------------------- Have you tested this on the try server yet? If yes, please provide a link to the results. I'd like to review a patch which has been fully tested, if possible, but this looks good so far. Also, I think you should be able to use Linux as a non-Mac platform here so you shouldn't need access to a Windows machine.
Attachment #686447 -
Flags: review?(ehsan) → feedback+
Assignee | ||
Comment 4•12 years ago
|
||
Hi. Yes, we tested on the try server. Here's the link with the results: https://tbpl.mozilla.org/?tree=Try&rev=927c1cc6b364 Everything went green :) .
Reporter | ||
Comment 5•12 years ago
|
||
Great!
Reporter | ||
Updated•12 years ago
|
Attachment #686447 -
Flags: review+
Reporter | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b94062c391cc
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•