Closed Bug 813215 Opened 7 years ago Closed 7 years ago

Port browser_354894.js to the per-window PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: marioalv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → andres
Status: NEW → ASSIGNED
This test is currently failing on Birch, and it's one of the blockers of getting Birch tests green.
Assignee: andres → marioalv.mozilla
Hi.
This patch is a Work In Progress patch. I don't have a Windows environment to test the Windows part of the patch, so our idea is to run the patch on the try server and see if everything works OK.

As the test comments state:
" * @note Mac only tests the new notifications, as restoring the last window is
 * not enabled on that platform (platform shim; the application is kept running
 * although there are no windows left)"

we can not test the Windows part on a Mac because there's no way to open/close/open the mochitest browser on a Mac, and this a is necessary step to do on this test.
Attachment #686447 - Flags: review?(ehsan)
Comment on attachment 686447 [details] [diff] [review]
Patch to migrate the test to the new per window private mode

Review of attachment 686447 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tested this on the try server yet?  If yes, please provide a link to the results.  I'd like to review a patch which has been fully tested, if possible, but this looks good so far.  Also, I think you should be able to use Linux as a non-Mac platform here so you shouldn't need access to a Windows machine.
Attachment #686447 - Flags: review?(ehsan) → feedback+
Hi.
Yes, we tested on the try server.
Here's the link with the results:
https://tbpl.mozilla.org/?tree=Try&rev=927c1cc6b364

Everything went green :) .
Great!
Attachment #686447 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/b94062c391cc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 817487
Target Milestone: --- → Firefox 20
Depends on: 824078
Depends on: 827739
You need to log in before you can comment on or make changes to this bug.