813226 - Add "always accept" preference

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Ability to short-circuit policy acceptance, v1

The B2G ADU ping is always enabled, so we need a way to short circuit display and acceptance of the data upload policy. This patch provides that.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Ability to short-circuit policy acceptance, v2

Minor change: We no longer record user acceptance of the policy. This makes it easier to handle the scenario where the ping didn't require user notification or acceptance and later does. This scenario may well happen with B2G.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 683212 [details] [diff] [review]
Ability to short-circuit policy acceptance, v2

Review of attachment 683212 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with name change, slightly more thorough precondition in test, typos.

I expect this'll need revision in the future, if some amount of data is always submitted, with opt-in for richer… but we'll burn that bridge when we come to it.

::: services/healthreport/healthreport-prefs.js
@@ +9,5 @@
>  pref("healthreport.logging.consoleLevel", "Warn");
>  pref("healthreport.policy.currentDaySubmissionFailureCount", 0);
>  pref("healthreport.policy.dataSubmissionEnabled", true);
>  pref("healthreport.policy.dataSubmissionPolicyAccepted", false);
> +pref("healthreport.policy.dataSubmissionPolicyAlwaysAccept", false);

s/AlwaysAccept/BypassAcceptance

::: services/healthreport/policy.jsm
@@ +361,5 @@
>  
>    /**
> +   * Short circuit policy checking and always assume acceptance.
> +   *
> +   * This shuld never be set by theer. Instead, it is a per-application or

"This shuld never be set by theer" indeed.

@@ +362,5 @@
>    /**
> +   * Short circuit policy checking and always assume acceptance.
> +   *
> +   * This shuld never be set by theer. Instead, it is a per-application or
> +   * per-deployment defalt pref.

s/defalt/default

::: services/healthreport/tests/xpcshell/test_policy.js
@@ +163,5 @@
> +
> +  prefs.set("dataSubmissionPolicyAlwaysAccept", true);
> +  defineNow(policy, new Date(policy.nextDataSubmissionDate.getTime()));
> +  policy.checkStateAndTrigger();
> +  do_check_eq(listener.requestDataUploadCount, 1);

Be explicit here and make sure that the acceptance pref is false -- you're testing state and not isolating all of it.

Comment 3

[Gregory Szorc [:gps]]

(In reply to Richard Newman [:rnewman] from comment #2)
> ::: services/healthreport/policy.jsm
> @@ +361,5 @@
> >  
> >    /**
> > +   * Short circuit policy checking and always assume acceptance.
> > +   *
> > +   * This shuld never be set by theer. Instead, it is a per-application or
> 
> "This shuld never be set by theer" indeed.

My keyboard has been doing weird things today - dropping key presses, etc. I swear it has!
> 
> ::: services/healthreport/tests/xpcshell/test_policy.js
> @@ +163,5 @@
> > +
> > +  prefs.set("dataSubmissionPolicyAlwaysAccept", true);
> > +  defineNow(policy, new Date(policy.nextDataSubmissionDate.getTime()));
> > +  policy.checkStateAndTrigger();
> > +  do_check_eq(listener.requestDataUploadCount, 1);
> 
> Be explicit here and make sure that the acceptance pref is false -- you're
> testing state and not isolating all of it.

test_prefs does this. However, the extra coverage can't hurt.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/projects/larch/rev/1174c5f0798b

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 683212 [details] [diff] [review]
Ability to short-circuit policy acceptance, v2

Bulk-setting approval flags for FHR landing for FxOS ADU ping (Bug 788894).

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1a3bae737a7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1a3bae737a7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0897cbed601b
https://hg.mozilla.org/releases/mozilla-beta/rev/0fca6ea06386