813271 - Rev the IID of nsIMarkupDocumentViewer

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Scott Johnson (:jwir3)]

Attachment: patch

In bug 780258, the interface nsIMarkupDocumentViewer changed, but the IID did not. This should be rectified to enforce binary incompatibility with plugins.

Comment 1

[Scott Johnson (:jwir3)]

Comment on attachment 683268 [details] [diff] [review]
patch

r+ by biesi via IRC.

Comment 2

[Scott Johnson (:jwir3)]

Comment on attachment 683268 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 780258
User impact if declined: Binary Incompatibility due to interface change
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): It's an IID change, and it needs to go into beta before the first spin. 
String or UUID changes made by this patch: Changes made to nsIMarkupDocumentViewer's IID.

Comment 3

[Scott Johnson (:jwir3)]

It looks like FF19 and FF20 are not affected after all, since there was a change to the IID in 204665ad4a24 (Bug 764240).

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 683268 [details] [diff] [review]
patch

[Triage Comment]
Approving for Beta 18 to make it into our first beta. Please land today.

Comment 5

[Scott Johnson (:jwir3)]

Landed on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/0e778097dc8c

Comment 6

[Scott Johnson (:jwir3)]

Comment on attachment 683268 [details] [diff] [review]
patch

It looks like bug 764240 didn't make the cutoff for the nightly->aurora transition, since it was backed out, so this bug does affect FF19.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 780258
User impact if declined: Binary Incompatibility due to interface change
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): It's an IID change, and it needs to go into beta before the first spin. 
String or UUID changes made by this patch: Changes made to nsIMarkupDocumentViewer's IID.

Comment 7

[Scott Johnson (:jwir3)]

Landed on aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/ff8902787b3c