813305 - marionette.py's check_for_crash() should use "PROCESS-CRASH | %s | foo" not "TEST-UNEXPECTED-FAIL - PROCESS CRASH - %s - bar"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Ed Morley [:emorley]]

...to be consistent with automation.py, peptest, mozcrash etc.

https://hg.mozilla.org/integration/mozilla-inbound/file/9f8721399b14/testing/marionette/client/marionette/marionette.py#l283
{
   283             print ('TEST-UNEXPECTED-FAIL - PROCESS CRASH - %s has terminated with exit code %d' %
   284                 (name, returncode))
}

should be of form:
http://hg.mozilla.org/mozilla-central/file/cf8750abee06/build/automationutils.py#l168
{
   168       log.info("PROCESS-CRASH | %s | application crashed (minidump found)", testName)
}

Comment 1

[Ed Morley [:emorley]]

(Note we can still keep the exit codes, it's more the prefix and pipes that we need to adjust)

Comment 2

[Jonathan Griffin (:jgriffin)]

I think this is really two bugs:

1 - remove the TEST-UNEXPECTED-FAIL prefix from PROCESS-CRASH messages
2 - use the logging module (or mozlog) instead of print

I'll fix 1 here and file a separate bug for 2

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Make Marionette's PROCESS-CRASH message the same as other harnesses,

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 697277 [details] [diff] [review]
Make Marionette's PROCESS-CRASH message the same as other harnesses,

Review of attachment 697277 [details] [diff] [review]:
-----------------------------------------------------------------

Really this should be using mozcrash, but good enough for now.

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/958f452fc41e

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/958f452fc41e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7d4ce445cbc2
https://hg.mozilla.org/releases/mozilla-b2g18/rev/79e44e9819d5