Closed Bug 813305 Opened 8 years ago Closed 8 years ago

marionette.py's check_for_crash() should use "PROCESS-CRASH | %s | foo" not "TEST-UNEXPECTED-FAIL - PROCESS CRASH - %s - bar"

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
mozilla20
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: emorley, Assigned: jgriffin)

References

Details

Attachments

(1 file)

...to be consistent with automation.py, peptest, mozcrash etc.

https://hg.mozilla.org/integration/mozilla-inbound/file/9f8721399b14/testing/marionette/client/marionette/marionette.py#l283
{
   283             print ('TEST-UNEXPECTED-FAIL - PROCESS CRASH - %s has terminated with exit code %d' %
   284                 (name, returncode))
}

should be of form:
http://hg.mozilla.org/mozilla-central/file/cf8750abee06/build/automationutils.py#l168
{
   168       log.info("PROCESS-CRASH | %s | application crashed (minidump found)", testName)
}
(Note we can still keep the exit codes, it's more the prefix and pipes that we need to adjust)
Blocks: 823076
I think this is really two bugs:

1 - remove the TEST-UNEXPECTED-FAIL prefix from PROCESS-CRASH messages
2 - use the logging module (or mozlog) instead of print

I'll fix 1 here and file a separate bug for 2
Comment on attachment 697277 [details] [diff] [review]
Make Marionette's PROCESS-CRASH message the same as other harnesses,

Review of attachment 697277 [details] [diff] [review]:
-----------------------------------------------------------------

Really this should be using mozcrash, but good enough for now.
Attachment #697277 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/958f452fc41e
Assignee: nobody → jgriffin
Whiteboard: [automation-needed-in-aurora][automation-needed-in-b2g18]
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/958f452fc41e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.