Closed Bug 813328 Opened 10 years ago Closed 10 years ago

IonMonkey: Add initialize() method to IonCompartment to allow for fallible initialization

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: djvj, Unassigned)

References

Details

Attachments

(1 file)

This would be helpful for baseline.  Baseline wants to stow its cache of stubCodes in IonCompartment, not IonRuntime.  This means initializing a WeakMap inside of it, which may potentially fail.

IonCompartment currently has no initialize() method to allow for fallible initialization.  This patch just adds a no-op initialize() method and instruments jscompartment to call it when initializing a new IonCompartment.

This will help avoid merge issues down the line with baseline development.
Attachment #683306 - Flags: review?(dvander)
Attachment #683306 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/bd4d746598fd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.