Closed
Bug 813328
Opened 12 years ago
Closed 12 years ago
IonMonkey: Add initialize() method to IonCompartment to allow for fallible initialization
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: djvj, Unassigned)
References
Details
Attachments
(1 file)
1.96 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This would be helpful for baseline. Baseline wants to stow its cache of stubCodes in IonCompartment, not IonRuntime. This means initializing a WeakMap inside of it, which may potentially fail. IonCompartment currently has no initialize() method to allow for fallible initialization. This patch just adds a no-op initialize() method and instruments jscompartment to call it when initializing a new IonCompartment. This will help avoid merge issues down the line with baseline development.
Attachment #683306 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #683306 -
Flags: review?(dvander) → review+
Comment 1•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bd4d746598fd
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•