Closed Bug 813373 Opened 9 years ago Closed 9 years ago

make all style rule classes have useful List methods

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(3 files)

While debugging bug 780692, nrc got confused by the style context dumps because some style rules don't implement a List method, which means that there are hidden rules in the list of rules that the style context represents.

All of our rules should have useful list methods; I'll attach a patch series to fix that.
Attachment #683370 - Flags: review?(dholbert) → review+
Attachment #683371 - Flags: review?(dholbert) → review+
Comment on attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.

r=me
Attachment #683372 - Flags: review?(bzbarsky) → review+
Comment on attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.

Review of attachment 683372 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I'm a bit late to the party, but should the printfs in this patch be fprintf/fputs?
You need to log in before you can comment on or make changes to this bug.