813373 - make all style rule classes have useful List methods

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While debugging bug 780692, nrc got confused by the style context dumps because some style rules don't implement a List method, which means that there are hidden rules in the list of rules that the style context represents.

All of our rules should have useful list methods; I'll attach a patch series to fix that.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: , patch 1: Remove pres context parameters from nsStyleAnimation::UncomputeValue.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: , patch 2: Remove pres context member from ValueWrapper.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: , patch 3: Make sure all style rules have non-empty List implementations.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e4b30b1d10
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cbf88ae52c5b
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/da575e9f17c4

Comment 6

[Nick Cameron [:nrc]]

Comment on attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.

Review of attachment 683372 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I'm a bit late to the party, but should the printfs in this patch be fprintf/fputs?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, indeed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f59f962f0b5c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6e4b30b1d10
https://hg.mozilla.org/mozilla-central/rev/cbf88ae52c5b
https://hg.mozilla.org/mozilla-central/rev/da575e9f17c4
https://hg.mozilla.org/mozilla-central/rev/f59f962f0b5c