If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

make all style rule classes have useful List methods

RESOLVED FIXED in mozilla20

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
While debugging bug 780692, nrc got confused by the style context dumps because some style rules don't implement a List method, which means that there are hidden rules in the list of rules that the style context represents.

All of our rules should have useful list methods; I'll attach a patch series to fix that.
(Assignee)

Comment 1

5 years ago
Created attachment 683370 [details] [diff] [review]
, patch 1:  Remove pres context parameters from nsStyleAnimation::UncomputeValue.
Attachment #683370 - Flags: review?(dholbert)
(Assignee)

Comment 2

5 years ago
Created attachment 683371 [details] [diff] [review]
, patch 2:  Remove pres context member from ValueWrapper.
Attachment #683371 - Flags: review?(dholbert)
(Assignee)

Comment 3

5 years ago
Created attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.
Attachment #683372 - Flags: review?(bzbarsky)
Attachment #683370 - Flags: review?(dholbert) → review+
Attachment #683371 - Flags: review?(dholbert) → review+
Comment on attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.

r=me
Attachment #683372 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

5 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e4b30b1d10
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cbf88ae52c5b
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/da575e9f17c4

Comment 6

5 years ago
Comment on attachment 683372 [details] [diff] [review]
, patch 3:  Make sure all style rules have non-empty List implementations.

Review of attachment 683372 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I'm a bit late to the party, but should the printfs in this patch be fprintf/fputs?
(Assignee)

Comment 7

5 years ago
Er, indeed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f59f962f0b5c
https://hg.mozilla.org/mozilla-central/rev/a6e4b30b1d10
https://hg.mozilla.org/mozilla-central/rev/cbf88ae52c5b
https://hg.mozilla.org/mozilla-central/rev/da575e9f17c4
https://hg.mozilla.org/mozilla-central/rev/f59f962f0b5c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.