Closed
Bug 813394
Opened 13 years ago
Closed 13 years ago
Check both |window.location| and |location| while navigated away in Location tests
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bholley, Assigned: bholley)
Details
Attachments
(1 file)
|
4.65 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I realized that our current navigated-away tests all do |window.location|, which effectively only checks the cross-compartment case. We should also check |this.location|, which is a different object when we're not the active page in the browsing context.
|
||
Comment 1•13 years ago
|
||
"this.location" and "window.location" had better return the same thing.
What will return something different is bareword "location".
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #1)
> "this.location" and "window.location" had better return the same thing.
>
> What will return something different is bareword "location".
Er, right! Thanks for pointing that out. :-)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #683417 -
Flags: review?(bzbarsky)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 683417 [details] [diff] [review]
Test both |window.location| and |location| in navigated-away-from frame. v1
r=me
Attachment #683417 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•