813471 - A breakpoint can be placed at the wrong line when using key shortcuts after opening the source editor's context menu

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

STR:
1. Right click on the source editor
2. Don't select any menu entry in the menu. Press ESCAPE instead.
3. Click on a different line
4. Hit Cmd+B

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/4c8114fbf1a9

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/4c8114fbf1a9

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 683506 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Under a certain combination of key shortcuts and context menus, breakpoints may get added on incorrect lines. 
User impact if declined: Almost none, this patch affects a developer tool.
Testing completed (on m-c, etc.): fx-team and m-c
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 683506 [details] [diff] [review]
v1

[Triage Comment]
Low risk fix for a new dev feature. Approving for Aurora 19.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b8452d1366e