813569 - Long string (ONE_MOMENT) not fully displayed in localized stub installer

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of the installer in Italian

See screenshot, bottom of the window.

The full string is "Ancora qualche istante, $BrandShortName verrà avviato al termine dell'installazione…", the last part is not displayed.

http://mxr.mozilla.org/l10n-central/source/it/browser/installer/nsisstrings.properties#29

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Went with allowing it to be multiline for the few cases where this happens. Also made the it so the set as default text does the right thing just in case. We might be able to add code to try to align this properly but we are going to go with this for at least the time being.

Comment 2

[Robert Strong (they/them - no direct email)]

Forgot to mention that the changes are just to the resources in other-licenses\nsis\nsisui.exe

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/80be27b3bb36

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/80be27b3bb36

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 734986 [details] [diff] [review]
patch rev1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Stub installer / bug 322206
User impact if declined: some locales will have cut off text
Testing completed (on m-c, etc.): manually verified and it has been on m-c for a while.
Risk to taking this patch (and alternatives if risky): minimal
String or IDL/UUID changes made by this patch: none

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/9c237bfb3f36

Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/eb1884787190

Comment 7

[Paul Silaghi, QA [:pauly]]

The text is complete on FF 21b7 stub installer en-US, it, fr.

Comment 8

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20100101 Firefox/22.0

Verified as fixed with FF 22 beta 1 (Build ID: 20130514181517) stub installer en-US, it and es-ES.

Comment 9

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 23b6 stub installer en-US, it, fr.