813575 - [Apps] When canceling the download of a packaged app, the attribute downloading is still set to true

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

When the download is canceled, the attribute 'downloading'continue being set to 'true' which IMHO should change to 'false'

Comment 1

[[:fabrice] Fabrice Desré]

We do set downloading to false at https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#761, which is then turned into a downloaderror at https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#593

I'll build a large package to get a chance to cancel the download and see what happens - my current tests apps download too fast.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Fabrice Desré [:fabrice] from comment #1)
> 
> I'll build a large package to get a chance to cancel the download and see
> what happens - my current tests apps download too fast.

You can try here:

http://owapps.cloudfoundry.com

Is an nodejs app that we created to testing in the different environments. You can run it local, the project is in github:
https://github.com/ferjm/apptester

Thanks.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

There were two different issues here: 

1. 'aApp' was undefined at [1], so the message was not being sent.

2. Once 1. was fixed, we ended up with two different 'ondownloaderror' events being fired (one of them with 'downloading' true). The first one requested from 'cancelDownload()' and the other requested by the handler[2] of the network error caused by the cancellation of the HTTP channel[3].

[1] https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#767
[2] https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#1381
[3] https://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#756

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11c5cc84a3fd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11c5cc84a3fd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a81094b387a2
https://hg.mozilla.org/releases/mozilla-beta/rev/ab5d992d637e