813594 - Gaping tabs strip after installing Facebook Toolbar

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Gap in the tabs strip

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0

After installing Facebook Toolbar 1.8.2 I've noticed a gap in the tabs strip.
Please see the attached screenshot for more details.
Reproduced the issue on Windows 7 and on Windows 8.

Reproducible: always

Steps to reproduce:
1. Install Facebook Toolbar and restart the browser.
https://addons.mozilla.org/en-US/firefox/addon/facebook-toolbar/?src=ss
2. Observe the tabs strip.

Expected results:
The installation of the toolbar does not affect the tabs strip.

Actual results:
There is a gap in the tabs strip after enabling the toolbar. If I enable the menu bar and I disabled it again the gap is gone (View menu -> Toolbars -> check and uncheck Menu Bar).

Comment 1

[u279076]

Is this a regression in either a previous version of Firefox or the add-on?

Comment 2

[Simona Badau, Desktop QA]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #1)
> Is this a regression in either a previous version of Firefox or the add-on?

I used the latest add-on version with several Firefox versions and there is no gap when enabling the Facebook Toolbar 1.8.2 between Firefox 4 and Firefox 15.
The issue is reproducible since Firefox 16.

Last good nightly: 2012-07-13
First bad nightly: 2012-07-14

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6489be1890c0&tochange=0602e44ac248

Comment 3

[Simona Badau, Desktop QA]

Reproducible also on the latest Nightly:
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20.0 Firefox/20.0
Build ID: 20121121030712

Comment 4

[u279076]

Simona, can you please use tinderbox builds to try to narrow down the regression range? There are a lot of changes in that pushlog.

Comment 5

[u279076]

Also, please see if any other "toolbar" add-ons trigger this behaviour. If not, it's likely an Extension Compatibility bug which the Facebook Toolbar developer needs to fix, not us.

Comment 6

[Simona Badau, Desktop QA]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #4)
> Simona, can you please use tinderbox builds to try to narrow down the
> regression range? There are a lot of changes in that pushlog.

The tinderbox builds from the time the regression occurred are not available anymore. I tried to build Firefox on my Windows 7 machine but I failed due to some Visual Studio errors.

Comment 7

[Simona Badau, Desktop QA]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #5)
> Also, please see if any other "toolbar" add-ons trigger this behaviour. If
> not, it's likely an Extension Compatibility bug which the Facebook Toolbar
> developer needs to fix, not us.

This behavior is not triggered by other add-ons like: Yahoo Toolbar, Image Toolbar, Amazon Toolbar, Online Translator Toolbar, SEO Toolbar, Netcraft Toolbar, XML Developer Toolbar, Quidco Toolbar, Orkut and Spiceworks Toolbar. 

Please note that Facebook Toolbar 1.8.2 did not trigger this behavior on the oldest Firefox versions (4-15) and the regression started with Firefox 16.

Comment 8

[u279076]

(In reply to Simona B [QA] from comment #6)
> The tinderbox builds from the time the regression occurred are not available
> anymore. 

Can you try the mozilla-inbound builds?

Comment 9

[Simona Badau, Desktop QA]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #8)
> (In reply to Simona B [QA] from comment #6)
> > The tinderbox builds from the time the regression occurred are not available
> > anymore. 
> 
> Can you try the mozilla-inbound builds?

Is there any place where I can find all the inbound-builds from that time (2012-07-13)?
I found the regression range on mozilla-inbound but the pushlog still contains a lot of changesets.

Last good nightly: 2012-07-12
First bad nightly: 2012-07-13

Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cf874e6
08c60&tochange=e9203900ce6c

I tried to build mozilla-inbound and find the exact changeset that introduced the regression but I can't because the bug is on Windows only and I keep getting some Visual Studio related errors that haven't allowed me to build.

Comment 10

[u279076]

mozilla-inbound builds from July can be found here:
ftp://ftp.mozilla.org/pub/firefox/nightly/2012/07/

Comment 11

[Simona Badau, Desktop QA]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #10)
> mozilla-inbound builds from July can be found here:
> ftp://ftp.mozilla.org/pub/firefox/nightly/2012/07/

I only found one mozilla-inbound build for the time the regression was introduced:
ftp://ftp.mozilla.org/pub/firefox/nightly/2012/07/2012-07-13-04-02-29-mozilla-inbound/

The issue is reproducible on the mozilla-inbound build from 2012-07-13 mentioned above:
Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/16.0 Firefox/16.0 
Build ID: 20120713040229

Comment 12

[Dana Lucaci, Desktop QA]

This issue is not reproducible anymore using the latest Firefox 123.0 build on Win 10. I'm closing it as WFM.