81362 - can't type in flash textboxs on Mac

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[shrirang khanzode]

I think there is a bug on this about keyboard events getting added twice...could 
not locate it

steps:

on mac trunk 0516, load the above test and hot any key in the textfield.
Observe that the character gets entered twice instead of once.

Comment 1

[sean echevarria]

Similar to bug 75582 - but it's about doubled mouse events.

Comment 2

[Peter Lubczynski]

This needs to be fixed before beta.

Comment 3

[shrirang khanzode]

target milestione?

Comment 4

[Peter Lubczynski]

Can I triage my own bugs? setting milestone....

Comment 5

[karnaze (gone)]

Moving to m0.9.2 (m0.9.1 indicates a beta stopper).

Comment 6

[Peter Lubczynski]

Here's another double keystroke bug. Could be a dup?

Comment 7

[Peter Lubczynski]

Brian, does your patch from bug 75582 fix this too? If so, can you mark a dup?

Comment 8

[Brian Nesse (gone)]

I have no idea. When I go to this page, I can't do anything... none of the
fields are active, I can't click in them, I can't type. I feel like I'm failing
an intelligence test somehow... 

Comment 9

[shrirang khanzode]

i see this too(mac branch 0605)...I cannot click and get the caret to focus al 
lthe time ( works once in a while) .however typing does not work at all...

Comment 10

[Peter Lubczynski]

This is pretty bad. Makes flash forms unusable. We must fix this. Changing 
testcase and summary from: 
double keyboard event appears in flash edit textfield
http://slip/shrir/flashedit.html

This seems to work in my debugger though. Brian, can you try in the debugger?

OS/2 may also have this problem. cc:ing mkaplay

Comment 11

[Brian Nesse (gone)]

Peter, not sure what you mean. I discovered this in a debug build, is that what
you're asking?

Comment 12

[Peter Lubczynski]

I can't reproduce this at all in a debugger, however, I totally see it when I 
run the build stand-alone. 

Hm....two things strike me:
1) Console outputs:
###!!! ASSERTION: NS_ENSURE_TRUE(objectFrame) failed: 
'objectFrame', file nsDOMClassInfo.cpp, line 2662
###!!! ASSERTION: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: 
'(!((rv) & 0x80000000))', file nsDOMClassInfo.cpp, line 2704

2) I wonder if ::OSEventAvail(0, &aMacEvent); inside 
nsPluginInstanceOwner::GUItoMacEvent() is effected by the debugger?

Brian, can you take a peek if the same is true for you? Otherwise, it's back 
to printf event debugging!

Comment 13

[Brian Nesse (gone)]

This bug is also a regression caused by the checkin for bug 64645. Additional 
information (and patch files) can be found in bug 76085. Applying the new patch 
from bug 76085 (attacment 37434) does not resolve this problem, but applying 
attachment 37415 [details] [diff] [review] (which backs out the 64645 checkin) does eliminate this bug.

Comment 14

[Peter Lubczynski]

Yet another regression from bug 64645? I'll try the patches from bug 76085 out
as soon as I can on these testcases. At least we have a handel on it.

Comment 15

[Brian Nesse (gone)]

Yeah, I've been alternately installing and uninstalling the various patches in
an attempt to localize the trouble spot. Unfortunately I (apparently) guessed
wrong as to which branch was causing the failure, so I'm doing it again...

Comment 16

[Brian Nesse (gone)]

Comparing the functionality of the old code (with the 64645 removal patch
installed) with the new patch code I see the same basic functionality in the
reflow process. Using the http://slip/shrir/flashedit.html testcase the Reflow()
goes through the preShell->CantRenderReplacedElement() case on the first pass
(drawing the purple background) and through the NotifyObjectContentWrapper()
method on the second pass (the flash edit fields). In other words, nothing
obvious... more investigation required.

Comment 17

[Brian Nesse (gone)]

The checkin for 76085 fixed the ability to type in the Flash textboxes, and the
checkin for bug 75582 fixed the double keystrokes (the original purpose for this
bug). This bug is fixed.

Comment 18

[shrirang khanzode]

verif fixed on 0613 trunk on mac. can type once again in flash textfields.