Closed
Bug 813723
Opened 13 years ago
Closed 13 years ago
Reorder state assignment in unit tests
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: ekr, Assigned: ekr)
Details
(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])
Attachments
(1 file, 2 obsolete files)
|
2.18 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #683735 -
Flags: review?(ethanhugg)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #683728 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•13 years ago
|
||
Fix race condition between test and set. Really, we want a lock
|
||
Comment 4•13 years ago
|
||
Comment on attachment 683735 [details] [diff] [review]
Reorder state assignment in unit tests
Review of attachment 683735 [details] [diff] [review]:
-----------------------------------------------------------------
I assume that OnCreate[Offer|Answer]Error and OnSetLocalDescriptionSuccess, etc. should be changed as well to make sure the lastStatusCode is set before the state as well?
Attachment #683735 -
Flags: review?(ethanhugg) → review+
|
|
||
Comment 5•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Attachment #683735 -
Attachment is obsolete: true
|
|
||
Updated•13 years ago
|
Attachment #683757 -
Flags: review?(ekr)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 683757 [details] [diff] [review]
Reorder state assignment in unit tests
Review of attachment 683757 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #683757 -
Flags: review?(ekr) → review+
|
||
Comment 7•13 years ago
|
||
I assume this isn't blocking but will land shortly
Priority: -- → P2
Whiteboard: [WebRTC], [blocking-webrtc-]
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•13 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•