813800 - ShouldRevalidateEntry() in imgLoader.cpp should return false for any data URI

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Currently data URIs end up getting revalidated in imagelib, which doesn't make much sense as they're immutable. Due to unfortunate details of the way validation is performed, a new imgRequest is created every time a data URI is revalidated, which is even more wasteful. We can avoid the problem entirely by returning |false| from ShouldRevalidateEntry() whenever we're dealing with a data URI.

Comment 1

[Seth Fowler [:seth] [:s2h]]

CC'ing Jason Duell on this just to make sure there isn't some hidden necko reason why revalidating data URIs is necessary.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: Never revalidate data URIs.

Proposed patch. Requesting review.

Comment 3

[Seth Fowler [:seth] [:s2h]]

(Ended up putting the check in ValidateEntry() instead of ShouldRevalidateEntry() since we have the URI available there and there are lots of similar checks in that spot.)

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 683809 [details] [diff] [review]
Never revalidate data URIs.

Review of attachment 683809 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure whether it makes more sense for this to be nearer the file:/// section above, but w/e.

Comment 5

[Seth Fowler [:seth] [:s2h]]

I was nervous to move it above the CORS/principal check without being really sure as to what I was doing. =)

Comment 6

[Seth Fowler [:seth] [:s2h]]

Try job here: https://tbpl.mozilla.org/?tree=Try&rev=74be7412b31a

Comment 7

[Seth Fowler [:seth] [:s2h]]

Try job looks OK. Requesting checkin.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37c36aa6f563

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Nice.

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/37c36aa6f563

Comment 11

[Mozilla RelEng Bot]

Try run for 74be7412b31a is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=74be7412b31a
Results (out of 256 total builds):
    success: 246
    warnings: 9
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-74be7412b31a