Closed Bug 813835 Opened 13 years ago Closed 13 years ago

Update toolchains to pick up external/libpng

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Platform:
All
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: mwu, Assigned: nthomas)

References

Details

We need external/libpng in the toolchain to land bug 809665. The B2G ICS opt/debug and ICS panda toolchains need this added.
Summary: Update gonk-misc in B2G snapshot to pick up external/libpng → Update toolchains to pick up external/libpng
Should we do unagi too, to keep them in sync ?
I've got unagi and panda snapshots done and a green try build for each. Need to find the snapshot docs/old bugs for the builds like 'b2g_mozilla-inbound_ics_armv7a_gecko build'.
Assignee: nobody → nthomas
Priority: -- → P2
jhford, could you provide some information on how to update the ICS toolchain ? AFAICT it's a call to B2G/scripts/toolchain.sh, but is there their any prior setup, eg a call to config <target> ?
Flags: needinfo?(jhford)
mwu, when I push bug 809665 along with the new panda/unagi snapshots there's still a problem with finding png for panda, see https://tbpl.mozilla.org/?tree=Try&rev=c760acedab7e If I look further at the snapshots external/libpng is present before and after, and isn't changing in my update. So some build issue ?
Is there a out/target/product/panda/obj/libpng.so in the panda toolchain tarball?
No, the snapshots we use for panda/unagi are the result of a './config.sh <target>' followed by a call to scripts/code-drop.sh, using an extra exclude list to ignore gecko/, gaia/, a bunch of prebuilt/. At build time there's no out/target/product/panda/obj/lib/libpng.so but there is an out/target/product/panda/obj/STATIC_LIBRARIES/libpng_intermediates/libpng.a
Oh, I didn't realize we're using the code-drop.sh script now. We probably just need a change to gonk-misc then.. Thanks for the heads up.
nthomas, fixing issue will require changes in the boot animation patch. It turns out I was relying on a shared library that's only generated on a codeaurora forum base. Sorry about the fuss. I won't be able to get a patch ready till next week so we might as well use the snapshot we have now if it fixes the random orange on tbpl.
Ok, thanks for the info. Proceeding with that on bug 810994.
(In reply to Nick Thomas [:nthomas] from comment #3) > jhford, could you provide some information on how to update the ICS > toolchain ? AFAICT it's a call to B2G/scripts/toolchain.sh, but is there > their any prior setup, eg a call to config <target> ? you'll need to ./config.sh <target> (cd scripts && ./toolchain.sh 7) # 7 is a the number that's put in the filename (cd scripts && VERSION=7 ./push-toolchain.sh) The push-toolchain.sh script understands how to checkout tooltool and create the new manifest, it also uploads things to the right place. It understands how to interpret REMOTE_HOST (include user@ here) and REMOTE_PATH as environment variables.
Flags: needinfo?(jhford)
And <target> should be 'emulator-x86' for the config.sh call ? Thanks for the info.
well, that's an available configuration, but that'd be for creating a snapshot that creates x86 emulator builds. For the generic gecko-only builds, we use the 'emulator' target, since that's building for the ARM target.
The new patch doesn't require a toolchain update, so closing this.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.