Closed
Bug 813885
Opened 13 years ago
Closed 13 years ago
RTCIceCandidate constructor arguments don't match spec
Categories
(Core :: WebRTC, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: padenot, Assigned: padenot)
Details
(Whiteboard: [WebRTC] [blocking-webrtc+] [qa-])
Attachments
(1 file)
Same general idea as bug 810458, we need to make the argument optional and set the all properties to null if no argument is passed, and if an argument is present, set the properties that are not present in the dict to null.
|
Assignee | |
Updated•13 years ago
|
Attachment #683911 -
Flags: review?(rjesup)
|
||
Comment 1•13 years ago
|
||
Note that any tests using this need to be reved as well (including landing-page on github)
Priority: -- → P1
Whiteboard: [WebRTC] [blocking-webrtc+]
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 683911 [details]
Make RTCIceCandidate respect the spec.
r+
Note any tests in the tree must be reved (also please check alder, as whimboo has been landing crashtests there until we get leaks fixed), and github. Test changes can be here or a separate bug, but I suggest landing them together if possible. Thanks!
Attachment #683911 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Assignee: nobody → paul
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•13 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc+] → [WebRTC] [blocking-webrtc+] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•