Closed
Bug 813918
Opened 12 years ago
Closed 12 years ago
nICEr code doesn't yet build on Android
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: gcp, Assigned: gcp)
References
Details
(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-][if you are here looking for c-c 921a79e71fff, its actually Bug 923165])
Attachments
(1 file, 2 obsolete files)
|
2.87 KB,
patch
|
dmosedale
:
review+
ted
:
feedback-
|
Details | Diff | Splinter Review |
WIP.
-D__UNUSED__="__attribute__((unused))"
is somehow clashing with this in an Android header:
unsigned long __unused[4];
I'm a bit baffled how that is even possible.
|
Assignee | |
Updated•12 years ago
|
Attachment #683947 -
Attachment is patch: true
|
||
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [WebRTC] [blocking-webrtc-]
|
|
Assignee | |
Comment 1•12 years ago
|
||
Changelog for NDK8c:
- Replaced struct member data __unused with __linux_unused in linux/sysctl.h and
linux/icmp.h to avoid conflict with #define __unused in sys/cdefs.h.
I'll workaround.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #683947 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #684063 -
Attachment is obsolete: true
Attachment #688266 -
Flags: review?(dmose)
Attachment #688266 -
Flags: feedback?(ted)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 688266 [details] [diff] [review]
Patch 1. v2 Fix nICEr for Android.
Review of attachment 688266 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/mtransport/third_party/nICEr/nicer.gyp
@@ +177,5 @@
> '../nrappkit/src/port/win32/include'
> ],
> }],
> + ## Linux
> + [ 'OS == "android"', {
... I think you know what I'm going to say here...
Attachment #688266 -
Flags: feedback?(ted) → feedback-
|
||
Comment 5•12 years ago
|
||
Comment on attachment 688266 [details] [diff] [review]
Patch 1. v2 Fix nICEr for Android.
r=dmose, with ted's suggested change
Attachment #688266 -
Flags: review?(dmose) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
|
||
Comment 8•11 years ago
|
||
comm-central changeset 921a79e71fff was checked-in with the wrong bug number. Please go to Bug 923165 instead.
Whiteboard: [WebRTC] [blocking-webrtc-] [qa-] → [WebRTC] [blocking-webrtc-] [qa-][if you are here looking for c-c 921a79e71fff, its actually Bug 923165]
You need to log in
before you can comment on or make changes to this bug.
Description
•