Closed
Bug 813935
Opened 12 years ago
Closed 12 years ago
Deadcode removal: offset is not used in nsDiskCacheStream
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
INVALID
People
(Reporter: alfredkayser, Assigned: alfredkayser)
References
Details
Attachments
(1 file, 1 obsolete file)
5.64 KB,
patch
|
Details | Diff | Splinter Review |
The offset parameter is not used in nsDiskCacheStream, neither in the InputStream nor in the OutputStream.
Offset passed to GetOuputStream is always zero.
Removing offset and the corresponding code will reduce code and enable to easier make the diskcachs code more robust.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → alfredkayser
Attachment #683965 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 2•12 years ago
|
||
Further testing proved that offset is sometimes not 0. Particularily for streaming videos, offset will not be zero. The first chunk is cached, and when the rest of the video is loaded the rest of the data is appended.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•