Deadcode removal: offset is not used in nsDiskCacheStream

RESOLVED INVALID

Status

()

Core
Networking: Cache
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: Alfred Kayser, Assigned: Alfred Kayser)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 683965 [details]
Deadcode removal

The offset parameter is not used in nsDiskCacheStream, neither in the InputStream nor in the OutputStream.
Offset passed to GetOuputStream is always zero.

Removing offset and the corresponding code will reduce code and enable to easier make the diskcachs code more robust.
(Assignee)

Comment 1

5 years ago
Created attachment 683966 [details] [diff] [review]
Deadcode removal
Assignee: nobody → alfredkayser
Attachment #683965 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Blocks: 572011
(Assignee)

Updated

5 years ago
Blocks: 814010
No longer blocks: 572011
(Assignee)

Comment 2

5 years ago
Further testing proved that offset is sometimes not 0. Particularily for streaming videos, offset will not be zero. The first chunk is cached, and when the rest of the video is loaded the rest of the data is appended.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.