814037 - is_displayed struggling with transforms

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

This problem is seen in the gaia music app. There are two album views whose elements are all un-hidden, but who transform onto the screen. Is_displayed() returns false for all these elements, regardless if they've been transformed into view or not.

Example element we're looking for:
https://github.com/mozilla-b2g/gaia/blob/ae5bb150ac188aa7ecd653b5276f6139e756e444/apps/music/js/music.js#L432

The css causing the transform is most likely this:
https://github.com/mozilla-b2g/gaia/blob/ae5bb150ac188aa7ecd653b5276f6139e756e444/apps/music/style/music.css#L112

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this a duplicate of bug 813583?

Comment 2

[David Burns :automatedtester]

Without investigating it further I dont think they are

Comment 3

[David Burns :automatedtester]

zac: is this priority still correct since you mentioned when I saw you last week that the test doesn't use the approach at the moment

Comment 4

[Zac C (:zac)]

Yes, it's not affecting that test anymore so the priortiy can be lowered.

Comment 5

[David Burns :automatedtester]

dropping priority as per zac's comment

Comment 6

[David Burns :automatedtester]

I have tried to replicate the issue and I can't :(

In the Music app I have 1 mp3 on the device and do the following

elem = self.marionette.find_element('css selector', '.tile-title-album')
elem.is_displayed()

When I have the screen at (http://pastebin.mozilla.org/2046102 paste pastebin contents to urlbar) then is_displayed() is returning True. On the other parts of the app it is returning False which is what I would expect.

If someone can give me an example of where it not doing the right thing, ideally with an example script, then I have will have a look again

Comment 7

[Zac C (:zac)]

I'm happy with the result of David's recent testing. If we stumble upon another bug we can reopen this or raise a new one.

Comment 8

[Zac C (:zac)]

I mean I'm happy with the result with regard to how it affects the smoke test work.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It sounds like we can close this bug. Please reopen if this issue reoccurs.

Comment 10

[Zac C (:zac)]

This (or at least this test case) has regressed and we can't run the music test anymore.

Every element inside the music app after the transform has occurred is returning displayed false.

The element appears to be off the screen, perhaps not taking into account the translateX/transform.

{u'y': 76, u'x': 320}
{u'width': 320, u'height': 60}

The source of the issue might be from this commit into the music app:
https://github.com/mozilla-b2g/gaia/commit/e13ac837676251c9a96e651fa29dfa09f0b6b3c9

Comment 11

[Zac C (:zac)]

Attachment: test case left on light simmer for 2 minutes to reduce

Comment 12

[David Burns :automatedtester]

Desktop try : https://tbpl.mozilla.org/?tree=Try&rev=c8f1e713501b
Mobile Try : https://tbpl.mozilla.org/?tree=Try&rev=9aefbed427ab

Comment 13

[David Burns :automatedtester]

Attachment: test case html

zac kindly created this html test case to show the issue

Comment 14

[David Burns :automatedtester]

Mobile try: https://tbpl.mozilla.org/?tree=Try&rev=537a4eb3a2f9
Desktop Try: https://tbpl.mozilla.org/?tree=Try&rev=0eeffe9ec8af

I forgot to add the test html for this

Comment 15

[David Burns :automatedtester]

try is green \o/

Comment 16

[David Burns :automatedtester]

Attachment: Check overflow x and overflow y during visibility checks

Actual fix at https://code.google.com/p/selenium/source/detail?r=9f5f32c0bfba7005d61e39c6f5662638b87bdad2# and will need to have the spec updated accordingly

Comment 17

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/0c181daeb66c

Comment 18

[Aaron Train [:aaronmt]]

♡

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c181daeb66c

Comment 20

[David Burns :automatedtester]

landed https://hg.mozilla.org/releases/mozilla-b2g18/rev/9e7ac1496ebd

Comment 21

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/002237bf7c0c