Closed
Bug 814050
Opened 12 years ago
Closed 12 years ago
XMLHttpRequest withCredentials setter no longer throws when the request is sync due to bindings snafu
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: regression, Whiteboard: [CORS-testsuite])
Attachments
(1 file, 1 obsolete file)
|
4.91 KB,
patch
|
peterv
:
review+
smaug
:
feedback+
|
Details | Diff | Splinter Review |
It's not declared as throwing in the IDL!
|
Assignee | |
Updated•12 years ago
|
Blocks: 732377
Keywords: regression
|
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #684071 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #684070 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [needs review] → [needs review][CORS-testsuite]
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [needs review][CORS-testsuite] → [need review][CORS-testsuite]
Comment on attachment 684071 [details] [diff] [review] XMLHttpRequest.withCredentials header should throw on main thread too, in some cases. Olli probably has an opinion on if the throwing behavior here is good.
Attachment #684071 -
Flags: feedback?(bugs)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 684071 [details] [diff] [review] XMLHttpRequest.withCredentials header should throw on main thread too, in some cases. Oh, yes, we explicitly added that exception. But managed to not add test for it? :(
Attachment #684071 -
Flags: feedback?(bugs) → feedback+
|
||
Comment 5•12 years ago
|
||
Comment on attachment 684071 [details] [diff] [review] XMLHttpRequest.withCredentials header should throw on main thread too, in some cases. Review of attachment 684071 [details] [diff] [review]: ----------------------------------------------------------------- Sigh. ::: content/base/test/test_xhr_withCredentials.html @@ +12,5 @@ > +<body> > +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=814050">Mozilla Bug 814050</a> > +<p id="display"></p> > +<div id="content" style="display: none"> > + Trailing whitespace.
Attachment #684071 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/279541c0d07c
Flags: in-testsuite+
Whiteboard: [need review][CORS-testsuite] → [CORS-testsuite]
Target Milestone: --- → mozilla20
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/279541c0d07c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•